Page MenuHomePhabricator

Upload on commons disabled
Closed, ResolvedPublic

Details

Reference
bz67387

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:42 AM
bzimport set Reference to bz67387.
bzimport added a subscriber: Unknown Object (MLST).

Raising importance since that's a very critical bug that's blocking hundreds (thousands?) of uploads on Commons right now.

(In reply to Krinkle from comment #2)

Likely caused by
https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
c6e84ba3

That was supposed to fix it.

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be backported to 1.24wmf11.

(In reply to Krinkle from comment #2)

Likely caused by
https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
c6e84ba3

Caused by? It was the commit to make it content language (not user language), which was backported and deployed to the cluster?

https://gerrit.wikimedia.org/r/#/q/Ife55252fa3a8c575d13c41420814f42b914aa90d,n,z

(In reply to Krinkle from comment #4)

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
backported to 1.24wmf11.

https://gerrit.wikimedia.org/r/142384

https://gerrit.wikimedia.org/r/142387

(In reply to Krinkle from comment #4)

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
backported to 1.24wmf11.

Was already backported as rEWME650ce038a86e 5 days ago. Guess that didn't fix it.

reedy@mw1017:/usr/local/apache/common/php-1.24wmf11/extensions/WikimediaMessages$ grep "UploadForm:initial" WikimediaMessages.php -A 10
$wgHooks['UploadForm:initial'][] = function() {

if ( wfMessage( 'licenses' )->inContentLanguage()->isDisabled() ) {
        throw new ErrorPageError( 'uploaddisabled', 'wikimedia-upload-nolicenses' );
}

};

It works on all other wikis, so there appears to be somehow something Commons-specific...

I see the problem, Commons is one of the few wikis with 'licenses' in $wgForceUIMsgAsContentMsg.

Change 143396 had a related patch set uploaded by SPQRobin:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396

Change 143396 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396

Change 143403 had a related patch set uploaded by Reedy:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403

Change 143403 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403

Works now. Thanks for fixing the bug so fast. :-)

Verified to work. Thanks again, guys.