Page MenuHomePhabricator

CirrusSearch: Regex knock on issues
Closed, ResolvedPublic

Description

Regex queries will need more time to run than the standard 10 seconds. We should give them 30 or something.

Also, we should improve the error message when a query times out.

Finally, we should *make sure* that the regex filter comes last in the chain of stuff that Elasticsearch does because we know it'll be the slowest thing. That way we're super duper sure that stuff like <<insource:foo insource:/foo/>> is actually faster then plain <<insource:/foo/>>.


Version: unspecified
Severity: normal

Details

Reference
bz67418

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:27 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz67418.

Change 144748 had a related patch set uploaded by Manybubbles:
Raise regex timeout to 120 seconds

https://gerrit.wikimedia.org/r/144748

Still need another patch - this one to make sure the regex comes last.

Change 144748 merged by jenkins-bot:
Raise regex timeout to 120 seconds

https://gerrit.wikimedia.org/r/144748

Change 145079 had a related patch set uploaded by Manybubbles:
Script filters are executed last

https://gerrit.wikimedia.org/r/145079

Change 145079 merged by jenkins-bot:
Script filters are executed last

https://gerrit.wikimedia.org/r/145079

Both patches have been merged, assuming bug is fixed.

Please re-open if that's not the case.