Page MenuHomePhabricator

Text does not appear in the place of icons when images are disabled
Closed, ResolvedPublic

Description

Steps to reproduce the problem

Start the Android browser
Disable images
Clear cache
Navigate to https://en.wikipedia.org
Type an article name in the search bar such as "piano"
When the search results appear select "Piano"

Problems:

  1. Nothing appears to the viewer to indicate that it is possible to log in and edit the page, such as a text button that says "edit" in place of the arrow icons that would appear if images were enabled
  1. The icon in the upper left corner that activates the left-hand slideout bar does not appear, so the user does not know that it is available unless the user clicks where the icon would be
  1. The lack of text in place of icons might also affect accessibility for blind users who use screen readers

Version: unspecified
Severity: enhancement
OS: other
Platform: Other

Details

Reference
bz67726

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:29 AM
bzimport set Reference to bz67726.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iWReoFnb

Confirmed on Chrome desktop. It's an enhancement in my view, there is no code for now to support non-image-loading setting if i'm right.

(Removed mobile tag because thats MF product :))

The better way to disable images on mobile is to go into your settings and turn "Images" off. This will hide all article images, but still show user interface images.

The interface still works for blind users because the text exists, it's just positioned off-screen (which I personally think is a bit hacky, but others disagree).

I'm inclined to mark WONTFIX unless someone has a relatively simple fix for this (that doesn't interfere with accessibility).

We should, however, at least have title attributes on everything.

It looks like two of the page actions, 'add image' and 'add to watchlist', don't have any text at all (and thus aren't accessible).

In alpha they have title attributes now but no text labels. Personally I think showing the labels themselves is more trouble than it is worth, so I wouldn't waste time doing that, especially given what Kaldari says about the disable images feature built into the product.

Actually this is also the case in stable since they use the Icon class.

Is there anything more we want to do here? e.g. detect when images are disabled and reveal the labels or are we happy to just rely on title attributes?

Jdlrobson claimed this task.

Closing then. Please open a new clear bug if there is anything left to do.