Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Krinkle
	Jul 11 2014, 5:04 PM

Description

It seems Gerrit is consistently including the dot after a url in the url causing loads of links to be broken.

This is hurting development and slowing work down by requiring people to often correct the link after ending up on a 404.

While this has been happening for a while now, I'm quite sure this wasn't always the case. Think it's a regression from 6-12 months ago.

Version: wmf-deployment
Severity: major

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:39 AM

• bzimport added a project: Gerrit.

• bzimport set Reference to bz67866.

• bzimport added a subscriber: Unknown Object (MLST).

I have no idea where exactly the given example links expose the problem.

(In reply to Andre Klapper from comment #1)

I have no idea where exactly the given example links expose the problem.

First one: the link at the end of the first line of the commit message.
Second one: the link in the last comment by Siebrand.

Bugzilla does it right, as you can see from the URL http://example.com/foo.

And yes, this bug is a pain!

Change 146425 had a related patch set uploaded by QChris:
Do not linkify trailing dot or comma

Change 146425 merged by Chad:
Do not linkify trailing dot or comma

Resetting status to "NEW", as both links mentioned in comment 2 are still broken.

(In reply to Tomasz W. Kozlowski from comment #5)

both links mentioned in comment 2 are still
broken.

Yes, that's expected, as the fix has been merged, but not yet deployed.

Still broken. Commit was merged 5 months ago. Was it still not deployed or was it undone due to an upgrade?

greg lowered the priority of this task from Medium to Low.Sep 10 2015, 11:05 PM

This seems better in 2.12.x?

Yeh deffintly fixed in gerrit 2.12 since I can open both of those links that are described in the description.

Closing as resolved, please reopen if the problem still happends.

The only one I carn't open is https://gerrit.wikimedia.org/r/#/c/145291/7,publish that's probably because gerrit now uses javascript from commits so dosent need that url any more.