Page MenuHomePhabricator

VisualEditor: Cursor positioning broken after about-grouped inline alien
Closed, ResolvedPublic

Description

From bug 58221:

Tilman Bayer 2014-07-14 04:16:20 UTC

Another example:

In https://en.wikipedia.org/w/index.php?oldid=616866203&veaction=edit , place the cursor left of "F" in the word "Former" in the first paragrah, and hit the delete key. The "F" is deleted correctly, but the cursor jumps two to the left (between "s" and ".").

Reproduced in Firefox and Chromium under Ubuntu 14.04.


Version: unspecified
Severity: major

Details

Reference
bz67985

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:29 AM
bzimport set Reference to bz67985.

Anywhere we do logical cursoring you get off by two errors, e.g. delete/backspace/arrow keys (after clicking)

The problem here appears to be the IPA template which returns two <span>s which are about-grouped (about="#mwtX"). I imagine the cursoring logic is expecting an alien to consist of only one node.

Change 146079 had a related patch set uploaded by Esanders:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146079

Change 146079 merged by jenkins-bot:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146079

Change 146137 had a related patch set uploaded by Jforrester:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146137

Change 146138 had a related patch set uploaded by Jforrester:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146138

Change 146137 merged by jenkins-bot:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146137

Change 146138 merged by jenkins-bot:
Prevent double counting of DM nodes in getNodeAndOffset

https://gerrit.wikimedia.org/r/146138

Change 146159 had a related patch set uploaded by Jforrester:
Update VE core submodule to rGVEDe3fa7ec85b9c

https://gerrit.wikimedia.org/r/146159

Change 146161 had a related patch set uploaded by Jforrester:
Update VE core submodule to rGVEDcfdb3a54f9d6

https://gerrit.wikimedia.org/r/146161

Change 146159 abandoned by Jforrester:
Update VE core submodule to rGVEDe3fa7ec85b9c

https://gerrit.wikimedia.org/r/146159

Change 146161 abandoned by Jforrester:
Update VE core submodule to rGVEDcfdb3a54f9d6

https://gerrit.wikimedia.org/r/146161

Change 146165 had a related patch set uploaded by Jforrester:
Update VE core submodule to rGVEDe3fa7ec85b9c

https://gerrit.wikimedia.org/r/146165

Change 146166 had a related patch set uploaded by Jforrester:
Update VE core submodule to rGVEDcfdb3a54f9d6

https://gerrit.wikimedia.org/r/146166

  • Bug 68037 has been marked as a duplicate of this bug. ***