Page MenuHomePhabricator

stuff displayed as 'null' in date autoexpander
Closed, ResolvedPublic

Description

http://snag.gy/rsY2B.jpg

various things (e.g. ui-toggler-label) in the date autoexpander are displayed as 'null'

I think Wikibase got changed to use ValueView 0.6.4 as part of https://gerrit.wikimedia.org/r/#/c/143328/ and might have introduced the issue.


Version: unspecified
Severity: normal

Details

Reference
bz68033

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:32 AM
bzimport set Reference to bz68033.
bzimport added a subscriber: Unknown Object (MLST).

wikidata-services wrote:

Commit pushed to msg-fallbacks at https://github.com/wmde/ValueView

https://github.com/wmde/ValueView/commit/8e7949cf6938fdda49e5c93e6039149bb688335a
Add fallbacks for critical messages

This is not a fix for bug 68033. But it's good to have fallbacks for
the most critical messages in case something is wrong. The "more"
message is the message next to the expand arrow in all experts.
The calendar model can very easily show the untranslated calendar
model name. In both cases the alternative was to show "null" which
is not helpful, doesn't show up in any log but makes the UI unusable
for no good reason.

Bug: 68033

Change 146476 had a related patch set uploaded by Thiemo Mättig (WMDE):
Fix reverted fix again

https://gerrit.wikimedia.org/r/146476

Change 146476 merged by jenkins-bot:
Fix reverted fix again

https://gerrit.wikimedia.org/r/146476