blockpageschecker.py fails on English Wikipedia
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Jul 17 2014, 10:33 AM

Description

Firstly, categoryToCheck is set to [[Category:Protected]] which is wrong.

When categoryToCheck is set to [[Category:Wikipedia protected pages]], it gives the following error because it has not been configured for English Wikipedia.

If blockpageschecker.py is run on

Loading [[OMICS Group]]...
Traceback (most recent call last):
  File "pwb.py", line 153, in <module>
    run_python_file(fn, argv, argvu)
  File "pwb.py", line 67, in run_python_file
    exec(compile(source, filename, "exec"), main_mod.__dict__)
  File "scripts/blockpageschecker.py", line 498, in <module>
    main()
  File "scripts/blockpageschecker.py", line 336, in main
    replaceToPerform = u'|'.join(TTP + TSP)
TypeError: unsupported operand type(s) for +: 'NoneType' and 'NoneType'
<type 'exceptions.TypeError'>

Support for English Wikipedia has been disabled since 2008 with this changeset, as 'en' was set to None for all the other configuration fields.

https://mediawiki.org/wiki/Special:Code/pywikipedia/5246

Version: core-(2.0)
Severity: normal

Details

Reference: bz68153

	Subject	Repo	Branch	Lines +/-
	Disable blockpageschecker for English Wikipedia	pywikibot/core	master	+20 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T52344 Set up unit test running for pywikibot/core
Resolved	jayvdb	T71068 split test suite into tests which depend on a server, and those that do not
Invalid	None	T72936 Important tasks to be solved (tracking)
Resolved	Xqt	T193968 Missing unittests for scripts (tracking)
Resolved	Xqt	T71069 Scripts which are not properly tested by script_tests (tracking)
Resolved	Xqt	T70153 blockpageschecker.py fails on English Wikipedia

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:40 AM

• bzimport added projects: Pywikibot-Scripts, good first task.

• bzimport set Reference to bz68153.

• bzimport added a subscriber: Unknown Object (????).

jayvdb created this task.Jul 17 2014, 10:33 AM

Aklapper added a project: Pywikibot.Nov 27 2014, 4:15 PM

jayvdb moved this task from Backlog to Wikimedia prod/labs issues on the Pywikibot-Scripts board.Nov 30 2014, 3:52 PM

Change 211650 had a related patch set uploaded (by Ladsgroup):
blockpageschecker configuration for English Wikipedia

https://gerrit.wikimedia.org/r/211650

gerritbot added a project: Patch-For-Review.May 17 2015, 8:39 PM

jayvdb updated the task description. (Show Details)May 20 2015, 9:39 PM

jayvdb set Security to None.

That patch doesnt fix this problem; it still fails in the same place. Here is the run command I used to test, with that patch applied.

$ python pwb.py blockpageschecker -family:wikipedia -lang:en -simulate
Loading categories...
Categories loaded, start!
Retrieving 60 pages from wikipedia:en.
WARNING: API warning (query): Too many values supplied for parameter 'pageids': the limit is 50
Loading [[How to edit]]...
[[How to edit]] is protected: this account can't edit it! Skipping...
Loading [[Arameans]]...
[[Arameans]] is protected: this account can't edit it! Skipping...
Loading [[Al Gore controversies]]...
[[Al Gore controversies]] is protected: this account can't edit it! Skipping...
Loading [[Template:Info]]...
Loading [[Brian Chase (Wikipedia prankster)]]...
[[Brian Chase (Wikipedia prankster)]] is protected: this account can't edit it! Skipping...
Loading [[Brian Chase (Wikipedia hoaxer)]]...
[[Brian Chase (Wikipedia hoaxer)]] is protected: this account can't edit it! Skipping...
Loading [[Brian Chase (hoaxer)]]...
[[Brian Chase (hoaxer)]] is protected: this account can't edit it! Skipping...
Loading [[Template:Fr]]...
Loading [[Template:Infobox Defunct company]]...
Loading [[Template:Clerknote]]...
Loading [[Create article]]...
[[Create article]] is protected: this account can't edit it! Skipping...
Loading [[Create an article]]...
[[Create an article]] is protected: this account can't edit it! Skipping...
Loading [[Create pages]]...
[[Create pages]] is protected: this account can't edit it! Skipping...
Loading [[Darko Trifunović]]...
[[Darko Trifunović]] is protected: this account can't edit it! Skipping...
Loading [[Creating a new page]]...
[[Creating a new page]] is protected: this account can't edit it! Skipping...
Loading [[British India]]...
[[British India]] is protected: this account can't edit it! Skipping...
Loading [[British Student Television]]...
[[British Student Television]] is protected: this account can't edit it! Skipping...
Loading [[Template:Anchors]]...
Loading [[Archimedes Plutonium]]...
[[Archimedes Plutonium]] is protected: this account can't edit it! Skipping...
Loading [[Create a wikipedia page]]...
[[Create a wikipedia page]] is protected: this account can't edit it! Skipping...
Loading [[English English]]...
[[English English]] is protected: this account can't edit it! Skipping...
Loading [[Douchebag]]...
[[Douchebag]] is protected: this account can't edit it! Skipping...
Loading [[Bearded Tit]]...
[[Bearded Tit]] is protected: this account can't edit it! Skipping...
Loading [[Aramean-Syriac people]]...
[[Aramean-Syriac people]] is protected: this account can't edit it! Skipping...
Loading [[*NSYNC]]...
[[*NSYNC]] is protected: this account can't edit it! Skipping...
Loading [[Gallo-Roman]]...
[[Gallo-Roman]] is protected: this account can't edit it! Skipping...
Loading [[9/11]]...
[[9/11]] is protected: this account can't edit it! Skipping...
Loading [[Wikipedia:Article wizard]]...
Loading [[Halo Waypoint]]...
[[Halo Waypoint]] is protected: this account can't edit it! Skipping...
Loading [[Template:Catmain]]...
Loading [[Hoofdpagina]]...
[[Hoofdpagina]] is protected: this account can't edit it! Skipping...
Loading [[ACE Flight 22]]...
[[ACE Flight 22]] is protected: this account can't edit it! Skipping...
Loading [[Blinky Bill's Extraordinary Excursion]]...
[[Blinky Bill's Extraordinary Excursion]] is protected: this account can't edit it! Skipping...
Loading [[Blinky Bill’s Extraordinary Balloon Adventure]]...
[[Blinky Bill’s Extraordinary Balloon Adventure]] is protected: this account can't edit it! Skipping...
Loading [[Create a bio]]...
[[Create a bio]] is protected: this account can't edit it! Skipping...
Loading [[Template:Auto images]]...
Traceback (most recent call last):
  File "pwb.py", line 239, in <module>
    if not main():
  File "pwb.py", line 233, in main
    run_python_file(filename, argv, argvu, file_package)
  File "pwb.py", line 88, in run_python_file
    main_mod.__dict__)
  File "./scripts/blockpageschecker.py", line 497, in <module>
    main()
  File "./scripts/blockpageschecker.py", line 335, in main
    replaceToPerform = u'|'.join(TTP + TSP)
TypeError: unsupported operand type(s) for +: 'NoneType' and 'NoneType'
<type 'exceptions.TypeError'>
CRITICAL: Waiting for 1 network thread(s) to finish. Press ctrl-c to abort

With the latest patch, it still doesnt do the right thing for templates. It outputs...

...
Loading [[Template:Auto images]]...
The page is editable for all, deleting the template...
...

but it doesnt actually edit [[Template:Auto images]]

I think it's another bug, I will create and fix it but it's not related to this one.

Ladsgroup mentioned this in T100887: blockpageschecker.py still tries to edit even the template is not there.May 30 2015, 12:10 PM

jayvdb triaged this task as Low priority.Jun 9 2015, 5:37 AM

Change 211650 merged by jenkins-bot:
Disable blockpageschecker for English Wikipedia

https://gerrit.wikimedia.org/r/211650

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2016, 10:20 PM

Ladsgroup closed this task as Resolved.Jan 29 2016, 10:28 PM

Ladsgroup assigned this task to Xqt.

blockpageschecker.py fails on English WikipediaClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

blockpageschecker.py fails on English Wikipedia
Closed, ResolvedPublic
Actions

Related Objects
Search...