Page MenuHomePhabricator

VisualEditor: [Regression wmf14] Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI
Closed, ResolvedPublic

Description

Screenshot

1.Open a page with VE in FF
2.Click on Link inspector icon
3.The inspector does not open up
4.Now again click on the link tool on the toolbar

Observed Result:
The link inspector opens up with distorted UI and the following error appears in the console

TypeError: manager.opening is null

See the screenshot attached


Version: unspecified
Severity: major

Attached:

Screen_Shot_2014-07-18_at_11.11.37_AM.png (591×1 px, 138 KB)

Details

Reference
bz68223

Event Timeline

This is also happening for Language inspector,math inspector,special character.
Its not that they are not opening on the first attempt, it takes too long to open it , so when I tried to open them second time , it throws that error and appears in broken way.

Change 148757 had a related patch set uploaded by Catrope:
Followup b141a7d23: don't display:none; the popup in the DesktopContext

https://gerrit.wikimedia.org/r/148757

Change 148757 merged by jenkins-bot:
Followup b141a7d23: don't display:none; the popup in the DesktopContext

https://gerrit.wikimedia.org/r/148757

Change 148770 had a related patch set uploaded by Jforrester:
Followup b141a7d23: don't display:none; the popup in the DesktopContext

https://gerrit.wikimedia.org/r/148770

Change 148770 merged by jenkins-bot:
Followup b141a7d23: don't display:none; the popup in the DesktopContext

https://gerrit.wikimedia.org/r/148770

Verified the fix in Betalabs and the backport on test2

Verified the fix in production