Page MenuHomePhabricator
Create Task
Maniphest T70224

Flow: old-style links to topics don't redirect, get Fatal exception of type Flow\Exception\InvalidInputException
Closed, ResolvedPublic
Actions

Description

Try the URL in the bug, see this error.

Before we had Topic:Rylnpvcpshj9n30s , links to topics and actions on topics were of the form Talk:<boardname>?workflow=<topic UUID>(&other params...). The Permalink action item generated these links, so there are numerous old posts and bugs with these URLs. They should redirect (301 Moved Permanently?) to the improved URL, ideally preserving other query string parameters and the fragment

See https://www.mediawiki.org/wiki/Flow/Architecture/URLs#Sample_Flow_URLs

Version: master
Severity: normal
URL: https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&workflow=rylnpvcpshj9n30s

Details

Reference
bz68224

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:28 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz68224.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Jul 18 2014, 6:15 PM
• DannyH added a comment.Jul 18 2014, 8:41 PM

In backlog: https://trello.com/c/mtU6Qzug

gerritbot added a comment.Jul 19 2014, 5:52 AM

Change 147554 had a related patch set uploaded by Spage:
Redirect old-style permalinks to new ones.

https://gerrit.wikimedia.org/r/147554

gerritbot added a comment.Jul 21 2014, 5:05 PM

Change 147554 merged by jenkins-bot:
Redirect old-style permalinks to new ones.

https://gerrit.wikimedia.org/r/147554

gerritbot added a comment.Jul 21 2014, 5:07 PM

Change 148105 had a related patch set uploaded by EBernhardson:
Redirect old-style permalinks to new ones.

https://gerrit.wikimedia.org/r/148105

gerritbot added a comment.Jul 21 2014, 5:44 PM

Change 148105 merged by jenkins-bot:
Redirect old-style permalinks to new ones.

https://gerrit.wikimedia.org/r/148105

Aklapper added a comment.Sep 1 2014, 12:46 PM

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

• Spage added a comment.Sep 24 2014, 3:04 AM

The patch was merged so the Fatal exception is gone and you're redirected, though poorly.

(In reply to spage from comment #0)

They should redirect (301 Moved
Permanently?) to the improved URL, ideally preserving other query string
parameters and the fragment

The other query string parameters are lost, so I filed new bug 68339

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL