Page MenuHomePhabricator

OOjs UI: ClippableElements should clip to the viewport, not the body
Closed, ResolvedPublic

Description

When clipping to the body, assume we have the viewport to render in.

Observed: http://i.imgur.com/PM4Uywk.png

Expected: http://i.imgur.com/Aoq2nYw.png


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:38 AM
bzimport added a project: OOUI.
bzimport set Reference to bz68370.

Change 148357 had a related patch set uploaded by Esanders:
Special case for measuring clippableContainer == body

https://gerrit.wikimedia.org/r/148357

Change 148357 merged by jenkins-bot:
Special case for measuring clippableContainer == body

https://gerrit.wikimedia.org/r/148357

  • Bug 54965 has been marked as a duplicate of this bug. ***
  • This bug has been marked as a duplicate of bug 54965 ***
matmarex subscribed.

We accidentally broke this again. Needs a less brittle fix.

Change 179523 had a related patch set uploaded (by Bartosz Dziewoński):
Account for <html> rather than <body> being the scrollable root in Chrome

https://gerrit.wikimedia.org/r/179523

Patch-For-Review

…needs a less brittle fix, but for now, this will have to do.

Change 179523 merged by jenkins-bot:
Account for <html> rather than <body> being the scrollable root in Chrome

https://gerrit.wikimedia.org/r/179523

Maybe we should make a tech-debt task for making this less brittle?