Currently, the extension uses this regex:
$re = '~<tvar\|([^>]+)>(.*?)</>~u';
when parsing the content of "tvar"[1], but this does not work if the content spans multiple lines, as in
https://www.mediawiki.org/w/index.php?title=Thumbnail_style_update&diff=1074482&oldid=1074458
I believe it would work if we set PCRE_DOTALL for this regex (if that is the case, this is an easy bug to fix, so I'm adding the appropriated keyword to the bug report).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add multi-line content for <tvar> & its unit tests | mediawiki/extensions/Translate | master | +62 -4 |
PCRE_DOTALL is the suffix 's'. http://fi2.php.net/manual/en/reference.pcre.pattern.modifiers.php
Please add a test case if submitting a patch.
Change 406421 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/Translate@master] Add support for multiple line in <tvar>
Change 406421 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add multi-line content for <tvar> & its unit tests
But please @D3r1ck01 how can someone determine if it has been resolved or not?
I'm still trying to get familiar with how we work around here
@Tamgue, usually, when a ticket is open and you're interested in working on it, try to see if the problem still exist by reproducing it. If it still exist, you can claim the task if you think you can do it and then fix the problem, then submit a patch. Members of the community will review your patch and if it's okay, it will be merged else you will need to improve on it until it's okay for merge. Then when you finish the task and it's merged, you or any other person can close the ticket on phabricator by marking it as resolved as it's completed.