Page MenuHomePhabricator

edit save failure, no discernible diagnostics
Closed, ResolvedPublic

Description

Save error

I have seen a number of tests failing where saving a change in the MF VE interface results only in a message "Error, edit not saved".

Here is one recent example: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/101/testReport/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Redirects/

There is no sign of this transaction in fatal.log, and I have not encountered it in a manual operation to check with developer tools.

Possibly related is an entry in dberror.log that may or may not correspond the failed edits:

Wed Jul 23 18:33:07 UTC 2014 deployment-mediawiki02 enwiki WikiPage::doEditContent: Transaction already in progress (from DatabaseBase::begin), performing implicit commit!
Wed Jul 23 18:53:37 UTC 2014 deployment-mediawiki02 enwiki WikiPage::doEditContent: Transaction already in progress (from DatabaseBase::begin), performing implicit commit!


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-07-23_at_12.23.16_PM.png (776×1 px, 105 KB)

Details

Reference
bz68465

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:27 AM
bzimport set Reference to bz68465.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4FzEwxyE

Oh, and the dberror.log seems to be unrelated, sorry about that.

Seems likely this is HHVM related, adding Ori and Bryan

Per http://lists.wikimedia.org/pipermail/qa/2014-July/001800.html sounds like this is likely related to the replag issues on betalabs; Chris mentioned he'll be checking back on this after a few days to see if this is actually resolved now.

I believe this is fixed with the change to allow longer replag.