Page MenuHomePhabricator
Create Task
Maniphest T70486

VisualEditor: Language dialog launched from inspector doesn't open in a global overlay
Closed, ResolvedPublic
Actions

Description

Environment-test2

steps-

1> open a page in VE and open language inspector.
2> Click upon "English" in the inspector, to open the Language Selector dialog.
3> Now click on Language selector icon on top of the page, beside the username link (This extension is used for viewing pages in the language specified by the user's preferences).
4> Notice dialog saying "Select a Language" appears and the Language Inspector gets closed.But the Language Selector dialog(with two-letter code for languages) is still open.

Version: unspecified
Severity: minor

Details

Reference
bz68486

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:28 AM
• bzimport added projects: VE-deploy-2014-07-31, VisualEditor-EditingTools.
• bzimport set Reference to bz68486.
Swainr created this task.Jul 23 2014, 10:57 PM
Esanders added a comment.Jul 27 2014, 3:31 PM

Those links at the top shouldn't be accessible when a dialog is open. The problem is that the language dialog is launched in a slightly different way to others because it is launched from an inspector, and isn't getting a 'global' overlay which would shield those links.

gerritbot added a comment.Jul 27 2014, 3:34 PM

Change 149635 had a related patch set uploaded by Esanders:
Make the overlay used by the language dialog global

https://gerrit.wikimedia.org/r/149635

gerritbot added a comment.Jul 29 2014, 11:29 PM

Change 149635 merged by jenkins-bot:
[BREAKING CHANGE] Fix ve.ui.Overlay classes

https://gerrit.wikimedia.org/r/149635

Swainr added a comment.Aug 1 2014, 7:08 PM

Issue Resolved.

Ryasmeen added a comment.Aug 4 2014, 10:22 PM

Hey Ritu, Can you specify the environment where you checked the fix?

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:59 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL