Page MenuHomePhabricator

VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec)
Closed, ResolvedPublic

Description

Chrome emits this notice when using VisualEditor anywhere.

'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach).

Looks like more than the typical deprecation, because it's been replaced with a no-op. No idea if we/Rangy are relying on it doing something. Could cause all kinds of weird state inconsistencies.


Version: unspecified
Severity: major

Details

Reference
bz68492

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:28 AM
bzimport set Reference to bz68492.

timdown wrote:

Rangy has no reliance on Range.detach now. The latest release does not use it at all.

(In reply to Tim Down from comment #1)

Rangy has no reliance on Range.detach now. The latest release does not use
it at all.

Unfortunately we still use the Rangy position plugin, which appears to have been unmaintained for a while. So we're stuck with our current version of rangy for now. Ideally I would like us to migrate away from the position plugin, then to a more recent version of Rangy. But I need to do a code audit to see is being used where.

As we've now dumped Rangy, this is now FIXED.