Page MenuHomePhabricator
Create Task
Maniphest T70546

VisualEditor Mobile: MobileContext is not in the DOM
Closed, ResolvedPublic
Actions

Description

Author: jgonera

Description:
When running VE on mobile, in the console:

$('.ve-ui-context')

$('.ve-ui-mobileContext')

I thought that the context not appearing on mobile was a CSS regression but it seems it's no longer attached to the DOM. Too tired today to figure out why (or to figure out how DesktopContext is attached to DOM).

Version: unspecified
Severity: major

Details

Reference
bz68546

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:32 AM
• bzimport added projects: VE-deploy-2014-07-31, VisualEditor-MediaWiki-Mobile.
• bzimport set Reference to bz68546.
• bzimport created this task.Jul 25 2014, 12:34 AM
gerritbot added a comment.Jul 25 2014, 6:10 PM

Change 149356 had a related patch set uploaded by Catrope:
[WIP] Attach mobile surface to the toolbar

https://gerrit.wikimedia.org/r/149356

gerritbot added a comment.Jul 25 2014, 11:24 PM

Change 149356 merged by jenkins-bot:
Attach mobile surface to the toolbar

https://gerrit.wikimedia.org/r/149356

Ryasmeen added a comment.Aug 4 2014, 10:09 PM

Verified the fix in Betalabs and test2

Ryasmeen added a comment.Aug 14 2014, 8:21 PM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:46 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL