Page MenuHomePhabricator

VisualEditor: VE gets stuck when applying changes to settings window the second time it's open
Closed, ResolvedPublic

Description

VE get stucks when saving settings

How to reproduce:

  1. click "Options" and then "cancel"
  2. click "Advanced settings" and then "apply changes"

After this it gets stuck. It's "applying changes" even if you didn't do any changes. You must reload the page to make your changes again.


Version: unspecified
Severity: normal

Details

Reference
bz68573

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:34 AM
bzimport set Reference to bz68573.

Can't reproduce this issue.

Stryn, do you get an error in the JS console when this happens?

(In reply to Alex Monk from comment #1)

Can't reproduce this issue.

Stryn, do you get an error in the JS console when this happens?

Yup, with Firefox and Chrome

Firefox gives:
TypeError: bindings[i] is undefined load.php:608

and Chrome:
Uncaught TypeError: Cannot read property 'context' of undefined VM51:8oo.EventEmitter.disconnect VM51:8ve.ui.MWCategoriesPage.teardown VM53:224(anonymous function) VM53:229(anonymous function) VM51:42OO.ui.Process.execute VM51:43OO.ui.Dialog.executeAction VM51:33OO.ui.ProcessDialog.executeAction VM51:74OO.ui.Dialog.onActionClick VM51:31oo.EventEmitter.emit VM51:7oo.EventEmitter.emit VM51:7OO.ui.ButtonWidget.onClick VM51:102proxy load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140724T1…:6jQuery.event.dispatch load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140724T1…:65elemData.handle

I think Ed fixed this in Gerrit change 148671

Yes, this is fixed in wmf15 (as on MediaWiki.org right now) but not in wmf14 (on enwiki etc.).