Page MenuHomePhabricator

Gerrit email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change."
Closed, DeclinedPublicFeature

Description

When you're going through an email backlog, you generally don't need to review every old version of an unmerged change (maybe just the latest), but you still may want to see every comment.

Having a separate subject line for "I'd like you to reexamine a change." vs. "jenkins-bot has posted comments on this change." would let you click through the comments, then just mark the remainder of the thread as read.

However, to work, this requires an email client that understands threading (using In-Reply-To and friends), so it might need to be an option.

Phabricator has an option for this reason ("Vary Subjects" / "This option adds more information to email subjects, but may break threading in some clients.") (http://fab.wmflabs.org/settings/panel/emailpreferences/).


Version: wmf-deployment
Severity: enhancement

Details

Reference
bz68598

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz68598.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to Matthew Flaschen from comment #0)

Having a separate subject line for "I'd like you to reexamine a change." vs.
"jenkins-bot has posted comments on this change." would let you click
through the comments, then just mark the remainder of the thread as read.

Sorry, Jenkins is not really relevant here (it applies for any new patch set posted vs. any user posting comments).

Aklapper triaged this task as Lowest priority.Mar 23 2015, 6:59 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:14 AM
hashar subscribed.

Gerrit now has the attention set feature ( https://gerrit.wikimedia.org/r/Documentation/user-attention-set.html ) which should help keeping track of changes one has to act on.

For email based workflows the solution is to add mail filters ( https://gerrit.wikimedia.org/r/settings/#MailFilters and https://gerrit-review.googlesource.com/Documentation/user-notify.html ). As an example whenever I get an email from Gerrit which comes from jenkins-bot I have a filter to label the message with ci-result and in my client I highlight it differently.