Maniphest T70655

Flow: Fix phpunit failure in SpamBlacklistTest::testSpam
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nemo_bis
	Jul 27 2014, 12:50 AM

Tags

Referenced Files

None

Subscribers

• wikibugs-l-list

Tokens

"Like" token, awarded by RandomDSdevel.

Description

The assumptions of this test may need to be verified, fails with http://paste.debian.net/111811/

Flow\Tests\SpamBlacklistTest::testSpam with data set #1 (Flow\Model\PostRevision, NULL, false)

Failed asserting that true matches expected false.

/srv/vagrant/mediawiki/extensions/Flow/tests/SpamBlacklistTest.php:61
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

Version: unspecified
Severity: normal

Details

Reference: bz68655

	Subject	Repo	Branch	Lines +/-
	Fix phpunit failure in SpamBlacklistTest::testSpam	mediawiki/extensions/Flow	master	+6 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		hashar	T60772 common gating job for mediawiki core and extensions
		Resolved		hashar	T69216 Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking)
		Resolved		EBernhardson	T70655 Flow: Fix phpunit failure in SpamBlacklistTest::testSpam

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:39 AM

• bzimport added a project: StructuredDiscussions.

• bzimport set Reference to bz68655.

• bzimport added a subscriber: Unknown Object (MLST).

Nemo_bis created this task.Jul 27 2014, 12:50 AM

Seems to be a bad relationship between Flow and AbuseFilter?

Added to backlog: https://trello.com/c/5pdNM3oi

Thanks for the report!

EBernhardson claimed this task.Dec 11 2014, 1:04 AM

EBernhardson triaged this task as Medium priority.

EBernhardson added a project: Collaboration-Team-Triage.

EBernhardson set Security to None.

EBernhardson moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.

EBernhardson moved this task from Sprint O (ends Jan 27) to Code Review on the Collaboration-Team-Triage board.

Change 179035 had a related patch set uploaded (by EBernhardson):
Fix phpunit failure in SpamBlacklistTest::testSpam

https://gerrit.wikimedia.org/r/179035

Patch-For-Review

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM

Change 179035 merged by jenkins-bot:
Fix phpunit failure in SpamBlacklistTest::testSpam

https://gerrit.wikimedia.org/r/179035

matthiasmullie mentioned this in rEFLW02f12dea4c80: Fix phpunit failure in SpamBlacklistTest::testSpam.Jan 13 2015, 1:32 PM

matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Triage board.Jan 13 2015, 3:40 PM

• DannyH moved this task from Product Review to Done (see also Status=Resolved) on the Collaboration-Team-Triage board.Jan 23 2015, 7:24 PM

Quiddity closed this task as Resolved.Jan 28 2015, 7:40 PM

Nemo_bis unsubscribed.Feb 1 2015, 5:23 PM

EBernhardson mentioned this in rMEXTc150542947e6: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:24 AM

RandomDSdevel awarded a token.Mar 29 2015, 10:28 PM