Page MenuHomePhabricator
Create Task
Maniphest T70677

VisualEditor: Typing over a link doesn't undo correctly
Closed, ResolvedPublic
Actions

Description

  1. Select a link fully
  2. Type one letter
  3. Press undo

Observer the first letter of the link is no longer linked.

Version: unspecified
Severity: normal

Details

Reference
bz68677

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:40 AM
• bzimport added projects: VE-deploy-2014-07-31, VisualEditor-DataModel.
• bzimport set Reference to bz68677.
Esanders created this task.Jul 27 2014, 1:15 PM
gerritbot added a comment.Jul 27 2014, 2:57 PM

Change 149633 had a related patch set uploaded by Esanders:
Copy annotation indexes before returning

https://gerrit.wikimedia.org/r/149633

Esanders added a comment.Jul 27 2014, 3:05 PM

The cause here is that the removal data in the transaction gets modified by annotationSet.removeAt(). Now the recorded removal data doesn't match the actual data that was there. If you created that link in this session then you also have have a sequence of transactions that don't connect.

gerritbot added a comment.Jul 28 2014, 9:57 PM

Change 149633 merged by jenkins-bot:
Copy annotation indexes before returning

https://gerrit.wikimedia.org/r/149633

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:00 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL