Page MenuHomePhabricator

VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open.
Closed, ResolvedPublic

Description

screenshot

Environment- test2

Steps-
1>1> Open a blank page in VE and type in some text.
2>At the end of the text insert a comment.
3>Click on the Comment , to open the comment edit dialog.
4> Now while the cursor is still in the comment edit dialog , click to insert a Template.
5> As you start typing, add any template from the list that shows likely matches. For Example -select the “Bar” template.
6>Type in Field name and insert the template.
7>Notice the template does get added and then a snowman like character gets triggered after it.

Behavior found in Chrome,FF and Safari.


Version: unspecified
Severity: major

Attached:

screenshot.png (233×1 px, 8 KB)

Details

Reference
bz68740

Event Timeline

confirmed in betalabs. Try the template "Bar chart"

Change 149920 had a related patch set uploaded by Catrope:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/149920

Change 149920 had a related patch set uploaded by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/149920

Change 149920 merged by jenkins-bot:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/149920

Change 150222 had a related patch set uploaded by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150222

Change 150222 abandoned by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150222

Change 150224 had a related patch set uploaded by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150224

Change 150224 abandoned by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150224

Change 150224 restored by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150224

Change 150224 abandoned by Jforrester:
Generate only one pair of snowmen for multi-sibling nodes

Reason:
I give up.

https://gerrit.wikimedia.org/r/150224

Change 150274 had a related patch set uploaded by Catrope:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150274

Change 150224 restored by Catrope:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150224

Change 150274 merged by jenkins-bot:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150274

Change 150224 merged by jenkins-bot:
Generate only one pair of snowmen for multi-sibling nodes

https://gerrit.wikimedia.org/r/150224

Should be now fully fixed in master; deployment to production scheduled for 4 hours' time.

Issue fixed in beta and test2

Created attachment 16120
screenshot_FF

Attached:

screenshot_FF.png (143×170 px, 1 KB)

In FF, the highlight seems to mask the comment icon.See screenshot_FF.