Page MenuHomePhabricator
Create Task
Maniphest T70784

CentralAuth tests are failing
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/mwext-CentralAuth-testextensions-master/191/console

04:46:15 1) CentralAuthHooksUsingDatabaseTest::testOnAbortNewAccount with data set #0 (UserNotExists, true)
04:46:15 Use of User::crypt was deprecated in MediaWiki 1.23. [Called from CentralAuthTestUser::__construct in /srv/ssd/jenkins-slave/workspace/mwext-CentralAuth-testextensions-master/extensions/CentralAuth/tests/CentralAuthTestUser.php at line 97]

04:46:15 2) CentralAuthPluginUsingDatabaseTest::testAuthenticate with data set #0 ('GlobalUser', 'GUP@ssword', true, 'Valid login for attached global')
04:46:15 Use of User::comparePasswords was deprecated in MediaWiki 1.23. [Called from CentralAuthUser::matchHash in /srv/ssd/jenkins-slave/workspace/mwext-CentralAuth-testextensions-master/extensions/CentralAuth/CentralAuthUser.php at line 1531]

Version: unspecified
Severity: normal

Details

Reference
bz68784

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:31 AM
• bzimport added a project: MediaWiki-extensions-CentralAuth.
• bzimport set Reference to bz68784.
• bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Jul 29 2014, 4:49 AM
gerritbot added a comment.Jul 29 2014, 5:00 AM

Change 150138 had a related patch set uploaded by Legoktm:
Stop using deprecated User::comparePasswords/User::crypt

https://gerrit.wikimedia.org/r/150138

Legoktm added a comment.Jul 29 2014, 5:04 AM

Other option is to remove the wfDeprecated calls from those two functions until CentralAuth is updated accordingly.

• csteipp added a comment.Jul 29 2014, 1:35 PM

I actually already had gerrit 141482 ready, which would also fix this, and checks for password upgrades. We should be fine doing either one right now.

gerritbot added a comment.Jul 29 2014, 3:00 PM

Change 150138 abandoned by Legoktm:
Stop using deprecated User::comparePasswords/User::crypt

Reason:
https://gerrit.wikimedia.org/r/#/c/141482/ is better

https://gerrit.wikimedia.org/r/150138

gerritbot added a comment.Jul 29 2014, 3:00 PM

Change 141482 had a related patch set uploaded by Legoktm:
Update CentralAuth for Password API

https://gerrit.wikimedia.org/r/141482

gerritbot added a comment.Jul 29 2014, 5:35 PM

Change 141482 merged by jenkins-bot:
Update CentralAuth for Password API

https://gerrit.wikimedia.org/r/141482

MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.May 5 2015, 5:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL