Page MenuHomePhabricator

VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null).
Closed, ResolvedPublic

Description

screenshot1

Environment- test2

Steps-
1> open a page in VE.
2> Insert ->Media.
3>Select to add a media file. Opens the Media Settings dialog.
4>Now click on “Caption” pane and Select Language from the text style menu, closes the drop down.
5>Cursor is at the beginning of the line. Click again on the style text menu to see that the Language is selected . See screenshots.
6> Notice typing the first letter deselects the Language from the drop-down, and so the language inspector never appears.


Version: unspecified
Severity: normal

Attached:

screenshot1.png (668×1 px, 96 KB)

Details

Reference
bz68808

Event Timeline

Created attachment 16089
screenshot2

Attached:

screenshot2.png (668×1 px, 96 KB)

Ed, is this fixed by gerrit 149635?

Change 150738 had a related patch set uploaded by Jforrester:
Set a default language for ve.dm.Document if we can't guess it otherwise

https://gerrit.wikimedia.org/r/150738

Change 150738 merged by jenkins-bot:
Set a default language for ve.dm.Document if we can't guess it otherwise

https://gerrit.wikimedia.org/r/150738

In Chrome and FF only the Language Inspector appears out of place when launched for the first time.The steps to reproduce are the same.See screenshot.Both in test2 and beta.

Created attachment 16121
screenshot

Attached:

screenshot.png (668×1 px, 101 KB)