Page MenuHomePhabricator

Wikivoyage displays "Fatal exception of type MWException" for 1.24wmf15
Closed, ResolvedPublic

Description

Author: himer2001

Description:
All Wikivoyage wiki's display "Fatal exception of type MWException" when I try to log in. Anonymous browsing is OK, though. I can also browse Wikipedia, Commons and other WMF projects when logged in. This problem appeared half an hour ago and correlates with the latest update of the MediaWiki software.


Version: wmf-deployment
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41209

Details

Reference
bz68815

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:33 AM
bzimport set Reference to bz68815.
bzimport added a subscriber: Unknown Object (MLST).

2014-07-29 19:01:10 mw1166 enwikivoyage: [2e0d46e3] /wiki/Special:CentralLogin/complete?token=d33043fa0c5a728c83cec79764df8521 Exception from line 4186 of /usr/local/apache/common-local/php-1.24wmf15/languages/Language.php: Invalid language code "WikiPedia"
#0 /usr/local/apache/common-local/php-1.24wmf15/languages/Language.php(4215): Language::getFileName('/usr/local/apac...', 'WikiPedia', '.php')
#1 /usr/local/apache/common-local/php-1.24wmf15/languages/Language.php(885): Language::getMessagesFileName('WikiPedia')
#2 /usr/local/apache/common-local/php-1.24wmf15/extensions/UniversalLanguageSelector/UniversalLanguageSelector.hooks.php(141): Language::fetchLanguageNames(NULL, 'mwfile')
#3 /usr/local/apache/common-local/php-1.24wmf15/extensions/UniversalLanguageSelector/UniversalLanguageSelector.hooks.php(222): UniversalLanguageSelectorHooks::isSupportedLanguage(NULL)
#4 [internal function]: UniversalLanguageSelectorHooks::getLanguage(Object(User), 'en', Object(RequestContext))
#5 /usr/local/apache/common-local/php-1.24wmf15/includes/Hooks.php(206): call_user_func_array('UniversalLangua...', Array)
#6 /usr/local/apache/common-local/php-1.24wmf15/includes/GlobalFunctions.php(4031): Hooks::run('UserGetLanguage...', Array, NULL)
#7 /usr/local/apache/common-local/php-1.24wmf15/includes/context/RequestContext.php(315): wfRunHooks('UserGetLanguage...', Array)
#8 /usr/local/apache/common-local/php-1.24wmf15/includes/Message.php(516): RequestContext->getLanguage()
#9 /usr/local/apache/common-local/php-1.24wmf15/includes/context/RequestContext.php(400): Message->setContext(Object(RequestContext))
#10 [internal function]: RequestContext->msg('centrallogin')
#11 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPage.php(606): call_user_func_array(Array, Array)
#12 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPage.php(464): SpecialPage->msg('centrallogin')
#13 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPage.php(360): SpecialPage->getDescription()
#14 /usr/local/apache/common-local/php-1.24wmf15/extensions/CentralAuth/specials/SpecialCentralLogin.php(25): SpecialPage->setHeaders()
#15 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPage.php(382): SpecialCentralLogin->execute('complete')
#16 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPageFactory.php(516): SpecialPage->run('complete')
#17 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#18 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(603): MediaWiki->performRequest()
#19 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(452): MediaWiki->main()
#20 /usr/local/apache/common-local/php-1.24wmf15/index.php(46): MediaWiki->run()
#21 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#22 {main}

So it's wmgExtraLanguageNames entries for Wikivoyage. If you remove WikiPedia, it then fails for Radreise-Wiki...

himer2001 wrote:

I am not sure if is related or not, but an important feature of today's MediaWiki update is the possibility to put inter-project links into the sidebar. However, Wikivoyage also had this possibility before through Extension:Related sites. This extension might have a conflict with the new version of the software. And if it does, I suggest to switch off Extension:Related sites immediately because it is no longer necessary anyway.

Change 150301 had a related patch set uploaded by Reedy:
Disable RelatedSites Extension

https://gerrit.wikimedia.org/r/150301

did you already disable it? because i don't see the error after logging in..

(In reply to atsirlin from comment #3)

I am not sure if is related or not, but an important feature of today's
MediaWiki update is the possibility to put inter-project links into the
sidebar. However, Wikivoyage also had this possibility before through
Extension:Related sites. This extension might have a conflict with the new
version of the software. And if it does, I suggest to switch off
Extension:Related sites immediately because it is no longer necessary anyway.

Which change is that exactly?

(In reply to Daniel Zahn from comment #5)

did you already disable it? because i don't see the error after logging in..

Yeah, wikivoyages were reverted to 1.24wmf14

himer2001 wrote:

I meant this one:
https://www.mediawiki.org/wiki/Beta_Features/Other_projects_sidebar

but well, I am not sure if it was included in the current release because I can't find any relevant changes for MediaWiki_1.24/wmf15

(In reply to atsirlin from comment #8)

I meant this one:
https://www.mediawiki.org/wiki/Beta_Features/Other_projects_sidebar

but well, I am not sure if it was included in the current release because I
can't find any relevant changes for MediaWiki_1.24/wmf15

It's apparently targetted for deployment later this month, but shouldn't have gone out already...

Dropping to major as site is functional on wmf14 (for now)

So, to clarify, the "In Other Projects Sidebar" is already in use on Wikivoyage, the target for later this month is for all wikis.

Katie/Marius: thoughts on this issue today?

himer2001 wrote:

I am sorry for the confusion about the RelatedSites extension. There is no reason to blame it for the current problem.

(In reply to Greg Grossmeier from comment #10)

So, to clarify, the "In Other Projects Sidebar" is already in use on
Wikivoyage, the target for later this month is for all wikis.

Katie/Marius: thoughts on this issue today?

Thanks. If the extensions is redundant it should be disabled (already made a patch for that above. Wants fully undeploying later)

I've not got round to looking if there were any related changes in the Language code. The Wikidata additional code seems a likely target (new only on Wikivoyage) but may not be the actual cause

(In reply to Greg Grossmeier from comment #10)

So, to clarify, the "In Other Projects Sidebar" is already in use on
Wikivoyage, the target for later this month is for all wikis.

Katie/Marius: thoughts on this issue today?

We don't plane to roll out our other project links to Wikibase this month (neither the beta feature not anything active per default).
The related sites extension does more than we support right now (as far as I'm aware).

(In reply to Marius Hoch from comment #13)

The related sites extension does more than we support right now (as far as
I'm aware).

Doesn't matter IMHO, we can't have two extensions competing for the same features enabled at the same time on the cluster, or even on an individual wiki. It's an unreasonable maintenance cost.

RelatedSites was already weird in that it implemented locally something that bug 708 had asked globally. IMHO, just undeploy RelatedSites immediately, file feature requests for any missing feature.

Wikivoyages back on 1.24wmf15

Change 150301 abandoned by Reedy:
Disable RelatedSites Extension

https://gerrit.wikimedia.org/r/150301