Page MenuHomePhabricator

Testsuite initialisation fails on Windows when pywin32 isnt installed
Closed, ResolvedPublic

Description

Under python 2.7.8, the default test loader for 'tests' tries to instantiate all files called '*_tests.py', and fails to instantiate the module 'ui_tests' when pywin32 is not installed.

> python setup.py test
running test
running egg_info
writing requirements to pywikibot.egg-info\requires.txt
writing pywikibot.egg-info\PKG-INFO
writing top-level names to pywikibot.egg-info\top_level.txt
writing dependency_links to pywikibot.egg-info\dependency_links.txt
reading manifest file 'pywikibot.egg-info\SOURCES.txt'
writing manifest file 'pywikibot.egg-info\SOURCES.txt'
running build_ext
WARNING: Running on Windows and transliteration_target is not set.
Please see https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Pywikibot/Wi
ndows
Traceback (most recent call last):
  File "...\setup.py", line 94, in <module>
    use_2to3=False
  File "C:\Python27\lib\distutils\core.py", line 152, in setup
    dist.run_commands()
  File "C:\Python27\lib\distutils\dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "C:\Python27\lib\distutils\dist.py", line 972, in run_command
    cmd_obj.run()
  File "build\bdist.win-amd64\egg\setuptools\command\test.py", line 138, in run
  File "build\bdist.win-amd64\egg\setuptools\command\test.py", line 118, in with
_project_on_sys_path
  File "build\bdist.win-amd64\egg\setuptools\command\test.py", line 164, in run_
tests
  File "C:\Python27\lib\unittest\main.py", line 94, in __init__
    self.parseArgs(argv)
  File "C:\Python27\lib\unittest\main.py", line 149, in parseArgs
    self.createTests()
  File "C:\Python27\lib\unittest\main.py", line 158, in createTests
    self.module)
  File "C:\Python27\lib\unittest\loader.py", line 128, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "C:\Python27\lib\unittest\loader.py", line 103, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "build\bdist.win-amd64\egg\setuptools\command\test.py", line 35, in loadT
estsFromModule
  File "C:\Python27\lib\unittest\loader.py", line 100, in loadTestsFromName
    parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute 'ui_tests'

Version: core-(2.0)
Severity: normal

Details

Reference
bz68847

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport added a project: Pywikibot-tests.
bzimport set Reference to bz68847.
bzimport added a subscriber: Unknown Object (????).
jayvdb triaged this task as Medium priority.Nov 29 2014, 5:00 PM
jayvdb updated the task description. (Show Details)
jayvdb set Security to None.
jayvdb removed a subscriber: Unknown Object (????).