Page MenuHomePhabricator

MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23
Closed, DeclinedPublic

Description

Author: sure4us

Description:
A number of people trying to install 1.23.1 + VE + Parsoid are finding an error that crashes the site.

https://www.mediawiki.org/wiki/Extension_talk:VisualEditor#MediaWiki_1.24wmf6_required_when_trying_to_install_VisualEditor_REL1.23_45012

I'm also experiencing it, here's the error messaging:

[d64ccb4d] /wiki/ Exception from line 3279 of /home/mywiki/public_html/wiki/includes/GlobalFunctions.php: MediaWiki 1.24wmf6 required--this is only 1.23.1

Backtrace:

#0 /home/mywiki/public_html/wiki/extensions/VisualEditor/VisualEditor.hooks.php(23): wfUseMW(string)
#1 [internal function]: VisualEditorHooks::onSetup()
#2 /home/mywiki/public_html/wiki/includes/Setup.php(601): call_user_func(string)
#3 /home/mywiki/public_html/wiki/includes/WebStart.php(156): require_once(string)
#4 /home/mywiki/public_html/wiki/index.php(43): require(string)
#5 {main}


Version: unspecified
Severity: normal

Details

Reference
bz68891

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:38 AM
bzimport set Reference to bz68891.

If they installed VisualEditor master, than that is bound to fail because it requires 1.24alpha (as all extensions do unless otherwise noted).

There is a REL1_23 branch[1] which requires 1.22 or higher (not 1.24alpha).

It seems however that the custom 1.23 download made available is packages from some arbitrary version not documented anywhere and that version contains "wfUseMW( '1.24wmf6' );" in its code.

I suggest whatever hacks were applied to produce this tarball are applied to REL1_23 following regular code review. If it's based on master instead of REL1_23, we can fast-forward REL1_23 to master and apply the fixes then.

Either way whatever we promote as 1.23-compat should be git and go through review. And when it does, it should be fixed to not require wfUseMW( '1.24wmf6' ); which is a bit silly for code explicitly made for 1.23.

[1] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/REL1_23
[2] https://www.mediawiki.org/wiki/Extension:VisualEditor

This sounds like the creation of the temporary tarball was very broken, but thanks to Kunal's work on ExtensionDistributor this should now be moot. Sorry for the troubles.