Page MenuHomePhabricator

Move Wikibase specific code out of page.py and site.py
Closed, ResolvedPublic

Description

Wikibase is an extension, and should have a wikibase.py instead of being in page.py and site.py

We already keep the tests in wikibase_tests.py.

URL: http://comments.gmane.org/gmane.comp.python.pywikipediabot.general/13886

Related tasks:
T108440: Pull out all Wikibase-related parts of pywikibot to pywikibot/wikibase and use it as a submodule
T112236: Extensible package design

Details

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:38 AM
bzimport set Reference to bz68898.
bzimport added a subscriber: Unknown Object (????).

Can we please work on getting the existing patches committed before the split.

We should delay new major patches until after the split.

Change 182407 had a related patch set uploaded (by Ricordisamoa):
Move Wikibase-specific code into wikibase.py

https://gerrit.wikimedia.org/r/182407

Patch-For-Review

Ricordisamoa changed the task status from Open to Stalled.Mar 19 2015, 10:11 PM
Ricordisamoa removed Ricordisamoa as the assignee of this task.
Ricordisamoa set Security to None.

Anyone is welcome to amend my Gerrit patch. I am not able to fix it myself.

Change 182407 abandoned by Ricordisamoa:
Move Wikibase-specific code into wikibase.py

Reason:
We have now pywikibot/wikibase

https://gerrit.wikimedia.org/r/182407

I am strictly against splitting main parts of the framework out of the current project. On bot owner side it is more difficult to combine a working bot, on developers side it is more difficult to check the code when it is distributed on several parts.

Xqt changed the task status from Stalled to Open.Jun 28 2017, 8:44 AM
Xqt triaged this task as Low priority.
Xqt claimed this task.

We already have the code splitted into site._datasite and page._wikibase