Page MenuHomePhabricator

VisualEditor: Toolbar should update fixed position after resize if MediaWiki layout changed (e.g. Vector skin goes below 982px SD/HD boundary)
Closed, ResolvedPublic

Description

When resizing the window, after a certain point the MediaWiki page layout may change (media queries). This affects the offset from the left side of the page (specifically, width of the sidebar).

However the toolbar caches its computed offset once and never updates it.

  1. Open window wider than 1024px with Vector skin in MediaWiki.
  2. Enter VisualEditor.
  3. Resize to < 980px.

Expected:

Sidebar shrinks (per Vector styles) and toolbar should still align with left edge of the page.

Actual:

Sidebar shrinks but toolbar stays behind causing an awkward gap to appear as well as odd interruption in the shadow. It results in part of the Save page button to go off-screen.

Other:

The reverse happens as well. Opening a narrow window and scaling it up will cause it to stay behind in the other direction. It results in part of the toolbar overlapping links in the sidebar.


Version: unspecified
Severity: minor

Details

Reference
bz68916

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:39 AM
bzimport set Reference to bz68916.

Created attachment 16109
Screenshot of bug.

Attached:

Screen_Shot_2014-07-31_at_13.09.22.png (500×2 px, 210 KB)

Change 169232 had a related patch set uploaded by Esanders:
Recalculate toolbar size on window resize

https://gerrit.wikimedia.org/r/169232

Change 169232 merged by jenkins-bot:
Recalculate toolbar size on window resize

https://gerrit.wikimedia.org/r/169232