Page MenuHomePhabricator

[[Corps]], [[Comet]], [[de:Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]] make the PDF renderer crash
Closed, ResolvedPublic

Description

Details

Reference
bz68929

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:40 AM
bzimport added a project: Collection.
bzimport set Reference to bz68929.

Change 150865 had a related patch set uploaded by Cscott:
Actually keep the temp image files...

https://gerrit.wikimedia.org/r/150865

Change 150865 merged by jenkins-bot:
Actually keep the temp image files...

https://gerrit.wikimedia.org/r/150865

(In reply to Andre Klapper from comment #3)

Is https://gerrit.wikimedia.org/r/#/c/150865/ (merged) worth to backport?

Yes, assuming someone confirmed it fixed the bug on beta.

mwalker wrote:

Um... I'm not sure what there is to backport? We are not yet branching any of the OCG code to WMF branches...

18:58 < greg-g> mwalker: that backport to WMF flag
18:58 < greg-g> it's code for "get this onto production"
18:58 < greg-g> which, with core is "backport to approrpiate wmfXX"
18:58 < mwalker> greg-g, ahh... that makes no sense at all, it should just be "deploy to production"
18:59 < greg-g> mwalker: sure, blame 1 month on the job me :)
18:59 < mwalker> damn you 1 month on the job greg-g!

mwalker wrote:

Well, we deployed the patch, but we're still seeing the bad exit. C.Scott tracked part of it down to a partially downloaded image, so we're going to have to debug that next.

I think I've fixed most of these cases -- the ones involving partially downloaded images at least.

But [[en:United States]] is still crashing. Have to continue to dig into this.

  • Bug 68835 has been marked as a duplicate of this bug. ***

Zweiter Weltkrieg, linked above, also fails.

(In reply to Nemo from comment #10)

Zweiter Weltkrieg, linked above, also fails.

And still does.

Change 160491 had a related patch set uploaded by GWicke:
Bug 68929: Use correct 'finish' event instead of 'close'

https://gerrit.wikimedia.org/r/160491

Note that this is actually a somewhat bogus bug -- the crashes above were caused by a number of different factors, including image truncation, improper escaping, and other things.

I'm leaving this open as a "[[Corps]], [[Comet]], [[Zweiter Weltkrieg]], [[First-move advantage in chess]], and [[United States]]" tracker bug. When those five articles are okay, I'll close this bug.

The deployment today (2014-09-15) has fixed [[United States]], [[Corps]], and [[First-move advantage in chess]]. [[Comet]] and [[de:Zweiter Weltkrieg]] are still broken.

Change 160491 merged by jenkins-bot:
Bug 68929: Use correct 'finish' event instead of 'close'

https://gerrit.wikimedia.org/r/160491

Tested, confirmed latest deployment fixes all these articles.