Page MenuHomePhabricator

watchlist.py should use a Cached ListGenerator
Closed, ResolvedPublic

Description

Bug 57995 adds a new script watchlist.py, ported from core.
The way the watchlist is cached should be upgraded to use CachedRequest.


Version: core-(2.0)
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:26 AM
bzimport set Reference to bz68988.
bzimport added a subscriber: Unknown Object (????).

It also uses dircache, which is removed from py 3.0 and needs to be replaced, but that will likely happen when the code is updated to use CachedRequest.

https://gerrit.wikimedia.org/r/#/c/172104/ implemented CachedRequest. The next task is to build a caching ListGenerator, and use that.

First step is to work around an oddity of watchlistraw.
https://gerrit.wikimedia.org/r/#/c/172103/

Change 215928 had a related patch set uploaded (by John Vandenberg):
Add support for CachedRequest in QueryGenerator

https://gerrit.wikimedia.org/r/215928

Change 216104 had a related patch set uploaded (by XZise):
[FEAT] Request: Separate MW API and PWB API params

https://gerrit.wikimedia.org/r/216104

Change 216104 merged by jenkins-bot:
[FEAT] Request: Separate MW API and PWB API params

https://gerrit.wikimedia.org/r/216104

Change 215928 abandoned by Ladsgroup:
Add support for CachedRequest in QueryGenerator

Reason:
Since 216104 merged

https://gerrit.wikimedia.org/r/215928