Page MenuHomePhabricator
Create Task
Maniphest T71022

Hardcoded path to Popups settings icon
Closed, ResolvedPublic
Actions

Description

The settings icon introduced in I374805e is hardcoded to reside at '/w/extensions/Popups/resources/gear_gray.svg' which can’t be right, it needs to be configuration-dependent. For instance, the code does not even work on the WMF cluster, where it leads to 404, check on the testwiki: https://test.wikipedia.org/w/extensions/Popups/resources/gear_gray.svg

Moreover, I don’t think using SVG files directly like this is acceptable, as older browsers do not support SVG. Cf. https://www.mediawiki.org/wiki/Manual:Assets

Version: unspecified
Severity: normal

Details

Reference
bz69022

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:29 AM
• bzimport added a project: Page-Previews.
• bzimport set Reference to bz69022.
• bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Aug 1 2014, 7:45 PM
• Spage added a comment.Aug 6 2014, 8:38 PM

A fix for both the path and SVG fallback is to put class mwe-popups-settings-icon on a span, and then use the background-image-svg( 'resources/gear_gray.svg', 'resources/gear_gray.png' ) LESS mixin.

Add a comment somewhere saying where the icon came from, and a @TODO use WikiFont glyph.

• Prtksxna added a comment.Aug 18 2014, 10:25 AM

With I3cf15bc4f9c9f1273b896d0e256f5821f15222fb it now correctly uses wgExtensionAssetsPath

gerritbot added a comment.Aug 19 2014, 4:54 PM

Change 155067 had a related patch set uploaded by Prtksxna:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067

gerritbot added a comment.Aug 20 2014, 2:12 PM

Change 155067 merged by jenkins-bot:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067

• Prtksxna moved this task from Backlog to Archive on the Page-Previews board.Dec 3 2014, 3:15 AM
Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 5:56 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 5:56 PM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL