Page MenuHomePhabricator

VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Go to the end of a line
3.Press return to go the next line and click on link inspector or comment icon from the toolbar

Observed Result:
The link inspector and the comment box opens at the end of the previous line
After adding a link or a comment it appears on the next line though.

See the screenshot attached

Environment:Betalabs and test2


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-08-04_at_1.27.06_PM.png (614×1 px, 111 KB)

Details

Reference
bz69122

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:35 AM
bzimport set Reference to bz69122.

(In reply to Rummana Yasmeen from comment #0)

Created attachment 16137 [details]
Screenshot

Steps to reproduce:

1.Open a page with mobile VE

That screenshot does not appear to be from a mobile device...

Attached:

Screen_Shot_2014-08-04_at_1.27.06_PM.png (614×1 px, 111 KB)

Right Alex :) This bug is not for mobile VE but for desktop. Sorry about that!

Language inspector also behaves in the same way

Yeah, selection is going very wonky here.

Change 155619 had a related patch set uploaded by Esanders:
Fallback to node position when getting selection rectangle

https://gerrit.wikimedia.org/r/155619

Change 155619 merged by jenkins-bot:
Fallback to node position when getting selection rectangle

https://gerrit.wikimedia.org/r/155619

Created attachment 16282
Screenshot

This is still happening,the inspectors are now opening not at the end of previous line, but somewhere along the preceding 4/5 lines

See the screenshot attached, where I tried to add a link inside the bullet list and it appears at some position in page title.

Attached:

Screen_Shot_2014-08-26_at_11.30.52_AM.png (407×696 px, 33 KB)

Change 157868 had a related patch set uploaded by Catrope:
Don't use three different coordinate systems in getSelectionRect()

https://gerrit.wikimedia.org/r/157868

Change 157868 merged by jenkins-bot:
Don't use three different coordinate systems in getSelectionRect()

https://gerrit.wikimedia.org/r/157868

*Verified the fix in production*

This is again happening for comment box in Betalabs

(In reply to Rummana Yasmeen from comment #14)

This is again happening for both link inspector and comment box in Betalabs

Got fixed with Ed's selection re-write I believe? I have not seen it happening recently too.Marking as fixed