Page MenuHomePhabricator

images are aligned incorrectly in MobileFrontend in RTL
Closed, ResolvedPublic

Description

To reproduce:

Go to https://he.wikipedia.org/wiki/%D7%99%D7%A4%D7%9F#.D7.94.D7.99.D7.A1.D7.98.D7.95.D7.A8.D7.99.D7.94 . This is the "History" section in "Japan". The image "JomonPottery" is correctly placed on the right-hand side.

Go to https://he.m.wikipedia.org/wiki/%D7%99%D7%A4%D7%9F#.D7.94.D7.99.D7.A1.D7.98.D7.95.D7.A8.D7.99.D7.94 using a device with a large screen - tablet or laptop. The same image is incorrectly placed on the left side.


Version: unspecified
Severity: normal

Details

Reference
bz69141

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:36 AM
bzimport set Reference to bz69141.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Zs5uRELl

Looks like the tleft & tright styles in Minerva are being RTL-flipped in ResourceLoader when they should be left literal. Needs a /* @noflip */ or something?

Change 151819 had a related patch set uploaded by Amire80:
Make sure that images are aligned correctly on wide screens

https://gerrit.wikimedia.org/r/151819

Change 151819 merged by jenkins-bot:
Make sure that images are aligned correctly on wide screens

https://gerrit.wikimedia.org/r/151819