Page MenuHomePhabricator

Magnify button goes to wrong image if thumbnail caption contains images
Closed, ResolvedPublic

Description

Minimal test case:
[[File:World location map.svg|thumb|Foo [[File:Example.png|10px]] bar]]

Clicking the magnify button just below the thumbnail will cause Example.png to be viewed instead of World location map.svg. To fix this, the target of the magnify link should always be used to determine which image it will open, rather than assuming that it's the same as some other image inside the thumbnail div.


Version: unspecified
Severity: normal

Details

Reference
bz69353

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz69353.
bzimport added a subscriber: Unknown Object (MLST).
Gilles subscribed.

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

I can reproduce at https://en.wikipedia.beta.wmflabs.org/wiki/T71353, but not at https://test2.wikipedia.org/wiki/T71353, which has $wgParserEnableLegacyMediaDOM = false. This can probably be closed once that option becomes the default.

TheDJ assigned this task to Arlolra.
TheDJ subscribed.

Confirmed fixed