Maniphest T71356

[regression] Site customizations doesn't work anymore
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	He7d3r
	Aug 9 2014, 10:59 PM

Tags

Referenced Files

None

Subscribers

• wikibugs-l-list

Description

Copying from I4ac5d190d83478945645d99af4aab68f640f0130.

Local customizations are not working on ptwiki anymore. I assume this change may be related. The problem was reported on my user talk page: https://pt.wikipedia.org/w/index.php?diff=39775860&oldid=39754826

To be more specific, it seems the custom list:

Is not loaded in production mode

https://pt.wikipedia.org/wiki/User_talk:Xyz?debug=0

Is loaded in debug mode

https://pt.wikipedia.org/wiki/User_talk:Xyz?debug=1
For example:

$.wikiLoveOptions.types.food.subtypes.feijoada

is undefined in production mode and is an object on debug mode.

Version: unspecified
Severity: normal
URL: https://pt.wikipedia.org/wiki/User_talk:Xyz

Details

Reference: bz69356

Related Objects

Mentioned In: T267039: User scripts/gadgets can load WikiLove wiki module without Wikilove dependencies

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:35 AM

• bzimport added a project: WikiLove.

• bzimport set Reference to bz69356.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Aug 9 2014, 10:59 PM

/me cluelessly wonders where to find those "local customizations"

https://pt.wikipedia.org/wiki/MediaWiki:WikiLove.js?uselang=en

Eh, I don't even remember what dark magic WikiLove was using and what I was trying to do. I'd just revert it at this point.

Possibly related: when I accessed the page
https://en.wikipedia.org/wiki/User:Cacycle/wikEd.js
I got "Exception thrown by ext.wikiLove.local"
load.php:161
"TypeError: $.wikiLoveOptions is undefined" TypeError: $.wikiLoveOptions is undefined
Stack trace:
@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z line 4 > eval:140:12196
runScript@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:171:166
execute/</checkCssHandles@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:171:567
execute@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:172:353
mw.loader</<.implement@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:178:172
@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z line 4 > eval:141:1
.globalEval/<@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:4:655
.globalEval@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:4:621
mw.loader</<.work@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:174:383
request@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:172:864
mw.loader</<.load@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140731T180219Z:179:743
@https://en.wikipedia.org/wiki/User:Cacycle/wikEd.js:19111:1

gerritadmin wrote:

Change 154002 had a related patch set uploaded by Legoktm:
Revert "Load ext.wikiLove.local via module dependencies"

https://gerrit.wikimedia.org/r/154002

gerritadmin wrote:

Change 154002 merged by jenkins-bot:
Revert "Load ext.wikiLove.local via module dependencies"

https://gerrit.wikimedia.org/r/154002

legoktm: Is more work needed, or does your patch entirely fix this?

Tacsipacsi mentioned this in T267039: User scripts/gadgets can load WikiLove wiki module without Wikilove dependencies.Nov 2 2020, 8:49 PM