Page MenuHomePhabricator

VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in link creation mode
Closed, ResolvedPublic1 Estimated Story Points

Description

For example, if you open the link tool on a blank page, there is nothing to "Remove" and nothing to "Open", so those buttons should be grayed out.


Version: unspecified
Severity: enhancement

Details

Reference
bz69359

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:35 AM
bzimport set Reference to bz69359.

(In reply to WhatamIdoing from comment #0)

For example, if you open the link tool on a blank page, there is nothing to
"Remove" and nothing to "Open", so those buttons should be grayed out.

  1. Click into a blank spot (e.g. the cursor is at '|' in "Foo | Bar")
  2. Enter a search term and select a link target

At this point, the only way to not insert this link is to click "Remove"; disabling it would mean that to not insert the link, you would have to empty the search box and then click "Done" (confusing) or outside the inspector (not possible in mobile).

Maybe we could come up with a different label, or maybe we don't care about this edge case enough?

Maybe relabel it "Cancel" instead in this case?

(In reply to Alex Monk from comment #3)

Maybe relabel it "Cancel" instead in this case?

Maybe.