Page MenuHomePhabricator

messages to logged-in user gone missing
Closed, ResolvedPublic

Description

Seen in beta labs: messages for user-already-logged-in and password-reset no longer appear.

Please see the test failures in login.feature at https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/150/testReport/ for details.


Version: unspecified
Severity: normal

Details

Reference
bz69475

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:43 AM
bzimport set Reference to bz69475.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BWhN8M1K

Either wrongly or rightly the desktop behaviour has changed

Going to http://127.0.0.1:8080/wiki/Special:Userlogin whilst logged in now redirects me to the main page.

As for password reset I'm seeing it but only when not logged in. I'm not sure why the test asserts Given I am logged in - why would you need to see a password reset in that situation?

Possibly a by-blow of https://gerrit.wikimedia.org/r/#/c/148144/ according to Matthew Flaschen. Reassigning this bug to Mediawiki not Mobile

Please let's keep it as a MobileFrontend bug as this is where the tests are passing. Personally I think the new behaviour is correct and we simply need to update the tests

Followup, the change to redirect away from UserLogin if you're already logged in was indeed intentional. See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/00b69eee50556880678ae491ebfcc01ebca96259/includes%2Fspecials%2FSpecialUserlogin.php#L240

(In reply to Jon from comment #2)

As for password reset I'm seeing it but only when not logged in. I'm not
sure why the test asserts Given I am logged in - why would you need to see a
password reset in that situation?

FWIW, I don't notice any behavior change on desktop for this. It pre-fills the username, then lets you reset the password.

The only reason you would do this is if you were currently logged in, but had forgotten your password (you also need your current password to change your password).

However, this is an edge case. If it doesn't behave that way on mobile, they have the option of logging out. (If you don't have an email set, you're out of luck either way, since changing an email also requires a password).

  • This bug has been marked as a duplicate of bug 70855 ***