Page MenuHomePhabricator

enable tab voting on DNS repo
Closed, ResolvedPublic

Description

Dear hashar,

recently you enabled tab voting in jenkins on the operations/puppet repo after we removed the last litereal tab chars.

Could you enable the same for operations/dns? I have recently retabbed all zone files and also the template(s).

grep -rP "\t" *

Merci beaucoup,

Daniel


Version: unspecified
Severity: enhancement

Details

Reference
bz69478

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:44 AM
bzimport set Reference to bz69478.

I have refactored the tabs job in Jenkins. The command I ended up with is:

echo "Looking for tabulations in files matching: {fileselector}"

set -x
(grep --recursive -P '^\t' --exclude-dir='.git' --include='{fileselector}' .) && HAS_TAB=1 || HAS_TAB=0
exit $HAS_TAB

Change 155277 had a related patch set uploaded by Hashar:
Create operations-dns-tabs

https://gerrit.wikimedia.org/r/155277

Change 155278 had a related patch set uploaded by Hashar:
Trigger operations-dns-tabs

https://gerrit.wikimedia.org/r/155278

Change 155278 merged by jenkins-bot:
Trigger operations-dns-tabs

https://gerrit.wikimedia.org/r/155278

Change 155279 had a related patch set uploaded by Hashar:
Jenkins test for tabs

https://gerrit.wikimedia.org/r/155279

Change 155277 merged by jenkins-bot:
Create operations-dns-tabs

https://gerrit.wikimedia.org/r/155277

Change 155279 abandoned by Hashar:
Jenkins test for tabs

Reason:
All good :)

https://gerrit.wikimedia.org/r/155279