Page MenuHomePhabricator

VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary
Closed, ResolvedPublic

Description

This is related to bug 50872.

If you click the edit link on a section, then that section's heading is pre-populated in the edit summary when you save.

This does not work very well if you have turned on https://en.wikipedia.org/wiki/MediaWiki:Gadget-edittop.js ("Add an [edit] link for the lead section of a page") in the gadgets for your preferences. Editing the first (lead) section of the page gets a suggested edit summary that includes the first section heading on the page i.e., the section heading immediately underneath the section you were actually editing.

The link for 'edit source' says:

https://en.wikipedia.org/w/index.php?title=User:WhatamIdoing&action=edit&section=0&summary=/*%20top%20*/%20

The link for 'edit' says:

https://en.wikipedia.org/w/index.php?title=User:WhatamIdoing&veaction=edit&vesection=1

The subsequent section editing links are all correct.


Version: unspecified
Severity: normal

Details

Reference
bz69501

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:45 AM
bzimport set Reference to bz69501.

It looks like the gadget needs to be fixed to deal with VE. In particular, it needs to be able to deal with 've' between the '&' and 'section='.

Although VE should probably pick up the default summary from the URL.

gerritadmin wrote:

Change 156744 had a related patch set uploaded by Alex Monk:
Pick up 'summary' parameter from URL to use as initial edit summary

https://gerrit.wikimedia.org/r/156744

gerritadmin wrote:

Change 156744 merged by jenkins-bot:
Pick up 'summary' parameter from URL to use as initial edit summary

https://gerrit.wikimedia.org/r/156744

I went back and fixed up that gadget so it should handle VE links correctly. This change to pick up 'summary' from the URL should take affect on all Wikipedias on Thursday (it should already be on test and test2).