Page MenuHomePhabricator

VisualEditor: Too much tabbing in the Template dialog
Closed, ResolvedPublic

Description

From John Broughton:

"This is what tabbing through Cite templates (in the mini-editors) looks like: type, tab, tab, tab, type, tab, tab, tab, type, ... You have to tab three times to get from one field to the next. That's because tabbing always includes both the “Field description” and “Remove field” icons. There isn't any reason to include these icons in tabbing; tabbing should bypass these icons."


Version: unspecified
Severity: minor

Details

Reference
bz69512

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:27 AM
bzimport set Reference to bz69512.

Also shift tab behaves differently (this is due to presence of icon only in focus state. WAI-ARIA has some further thoughts on how bot build fields like this, but I think it might be a bit too much effort right now.)

Using an actual button might fix 'excessive' tabbing here, since browsers sometimes have different default tab behavior for buttons vs. fields, a behavior overridden if you need to force button behaviors on a div/a.

(In reply to WhatamIdoing from comment #0)

From John Broughton:

[…]

There isn't any reason to include these icons in tabbing

The reason is "accessibility". That's a pretty strong sine qua non for how we build things.

(In reply to Derk-Jan Hartman from comment #1)

Using an actual button might fix 'excessive' tabbing here, since browsers
sometimes have different default tab behavior for buttons vs. fields, a
behavior overridden if you need to force button behaviors on a div/a.

Using a <button> rather than a <div> in OOUI for buttoned elements takes us into really horrible issues more widely, though…

(In reply to James Forrester from comment #2)

Using a <button> rather than a <div> in OOUI for buttoned elements takes us
into really horrible issues more widely, though…

Can you elaborate, because I don't see why that would be ? We have gotten them pretty down even in mediawiki.ui

  • This bug has been marked as a duplicate of bug 68768 ***