[HHVM] Tests on Travis are failing (due to PHPUnit version used)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tobi_WMDE_SW
	Aug 14 2014, 9:35 AM

Description

This is due to the PHPUnit version used.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=5

Details

Reference: bz69524

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T72716 cannot save badges on Q183 (Germany)
Resolved	None	T73519 Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on)
Resolved	Lydia_Pintscher	T66415 Make Wikibase compatible with HHVM
Resolved	JeroenDeDauw	T71524 [HHVM] Tests on Travis are failing (due to PHPUnit version used)

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:28 AM

• bzimport added a project: MediaWiki-extensions-Diff.

• bzimport set Reference to bz69524.

• bzimport added a subscriber: Unknown Object (MLST).

Tobi_WMDE_SW created this task.Aug 14 2014, 9:35 AM

We are using the TravisCI default, which is PHPUnit 4.x. I recall Sebastian saying he fixed HHVM compat, so I'm not sure what the issue there is. Will investigate.

Jeroen De Dauw

Jeroen, any updates?

Core uses PHPUnit too, and its unit tests are passing with Travis CI under HHVM.

I think this was fixed?

Sorry not true: https://travis-ci.org/wmde/Diff/jobs/38707716

Probably needs a change like in https://github.com/wmde/WikibaseDataModel/commit/3dd5504a1a6568e6a8d237184ee578c3352cfc61

Unless there are breaking changes we made for HHVM support, I suggest be backport the changes onto the 1.x branch and do a 1.1.0 release rather than already releasing 2.0. I do not think a breaking release otherwise justifies the hassle it causes.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:29 PM

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).Dec 1 2014, 2:32 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Dec 15 2014, 2:42 PM