Page MenuHomePhabricator

[PagePreparation] Link to edit and language in summary
Open, MediumPublicBUG REPORT

Description

After confirming the action from Special:PagePreparation, I got a link to https://www.mediawiki.org/wiki/Extension:ConfirmAccount?action=edit and in the history I see https://www.mediawiki.org/w/index.php?title=Extension%3AConfirmAccount&diff=1107033&oldid=1012488

  1. The link should not append ?action=edit but use fullurl: https://www.mediawiki.org/wiki/Help:Magic_words#URL_data
  2. the edit summary should be in content language, not in my interface language.

Details

Reference
bz69592

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:32 AM
bzimport set Reference to bz69592.

pr4tiklahoti wrote:

(In reply to Nemo from comment #0)

  1. The link should not append ?action=edit but use fullurl:

https://www.mediawiki.org/wiki/Help:Magic_words#URL_data

Why so? As we are saying "You can [edit] it", it would be better to take the user to the editing window, I feel.

Change 154398 had a related patch set uploaded by BPositive:
Edit summary in content language at Special:PagePreparation

https://gerrit.wikimedia.org/r/154398

pr4tiklahoti wrote:

Also, the same behavior for edit summary is expected in case of Special:PageMigration.

Change 154398 merged by jenkins-bot:
Edit summary in content language at Special:PagePreparation and Special:PageMigration

https://gerrit.wikimedia.org/r/154398

Is it now using a fullurl for the action=edit link?

  • Bug 69945 has been marked as a duplicate of this bug. ***

pr4tiklahoti wrote:

Hi Nemo,

Why so? As we are saying "You can [edit] it", it would be better to take the
user to the editing window, I feel.

I had mentioned this, you din't reply. It does not use the full URL in the merged patch.

Ok. Please look at https://www.mediawiki.org/wiki/Help:Magic_words#URL_data again, the second example shows how an action=edit URL should look.

Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 5 2022, 2:33 PM
Aklapper removed a subscriber: Jsahleen.
Tacsipacsi subscribed.

It uses, and has always used (ever since it was introduced in a65a6a2), mw.Title.getUrl(). I didn’t try Special:PagePreparation (I didn’t want to create garbage), but trying out mw.Title.getUrl() directly, it should emit URLs that include index.php. (Even though I don’t think it should look like that – it can look however it happens to look like, as long as it works for any title, even those that contain question marks and the like.)