Page MenuHomePhabricator

Move message box before header, to not have the message to finish in the middle, when an extension extends the Login form
Closed, InvalidPublicFeature

Description

Actually the messagebox ($this->data['message']) comes after "header" (which can be set by an Extension, e.g. GoogleLogin). The message box is used (e.g.) to show messages like "Please login to change your preferences." when the user requested Special:Preferences and isn't logged in.

I would suggest to move this message box before the header (after warningbox with "you are already logged in"). Reason: An Extension like GoogleLogin extends the Login form with several form fields, but the message, that the user has to login to finish his action is somewhere in the middle of the form (after the extension output). This looks crappy. Another solution could be to add another section like "afterMessages" or something like. Would be great to have a better solution for this :)


Version: 1.24rc
Severity: enhancement

Details

Reference
bz69611

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:34 AM
bzimport set Reference to bz69611.
bzimport added a subscriber: Unknown Object (MLST).
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:23 PM
Aklapper removed a subscriber: wikibugs-l-list.
matmarex subscribed.

I don't think this is meaningful any more… The code this report is referring to has been removed with the introduction of AuthManager in 2016 (rMW854a462dc0ae: Remove $wgDisableAuthManager).