Page MenuHomePhabricator
Create Task
Maniphest T71639

Regression test failure: "The builder for vector returned a non-Skin object"
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/150635/ passed the gating check normally and merged. However, the regression test failed with:

"00:54:27 1) SpecialMIMESearchTest::testMimeFiltering with data set #1 ('image/png', 'image', 'png')
00:54:27 UnexpectedValueException: The builder for vector returned a non-Skin object."

and:

"00:54:27 2) SpecialMIMESearchTest::testMimeFiltering with data set #3 ('image/*', 'image', NULL)
00:54:27 UnexpectedValueException: The builder for vector returned a non-Skin object."

Full error details: https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/7024/console

I'm guessing it was not actually caused by that change, but we'll have to track it down either way.

Version: 1.24rc
Severity: normal

Details

Reference
bz69639

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:36 AM
• bzimport added projects: MW-1.24-release, MediaWiki-Core-Tests.
• bzimport set Reference to bz69639.
• Mattflaschen-WMF created this task.Aug 16 2014, 1:50 AM
• Mattflaschen-WMF added a comment.Aug 16 2014, 1:51 AM

Perhaps the workspace used for this test does not yet install Vector.

Legoktm added a comment.Aug 16 2014, 5:43 AM

Apparently the tests run in different orders in weird circumstances.

gerritbot added a comment.Aug 16 2014, 5:51 AM

Change 154384 had a related patch set uploaded by Legoktm:
Register a fake skin instead of a 'vector' that will fail

https://gerrit.wikimedia.org/r/154384

hashar added a comment.Aug 16 2014, 8:48 AM

side note: I will eventually get the skins cloned in the workspace :)

hashar added a comment.Aug 16 2014, 8:50 AM

Oh and I forgot: the regression test that runs on postmerge runs the whole test suite, so there might be some side effects comparing to running group of tests in parallel :-/ We will eventually phase out the sub groups in favor of running the whole test suite.

gerritbot added a comment.Aug 16 2014, 9:42 AM

Change 154384 merged by jenkins-bot:
Register a fake skin instead of a 'vector' that will fail

https://gerrit.wikimedia.org/r/154384

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL