Let's stop using inline <img> for thumbnail magnify icon. According to bug 69277 comment 11, there are 87619775 requests per day for 'magnify-clip.png'. It should be embedded in some piece of CSS.
(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the icon, but it would only affect the Vector skin.)
Version: 1.24rc
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T29292 Skinning system improvement (tracking) | |||
| Resolved | matmarex | T71277 Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else | |||
| Resolved | Jdforrester-WMF | T71705 "Enlarge" icon (magnify-clip.png) missing a SVG version | |||
| Resolved | matmarex | T71673 Stop using inline <img> for thumbnail magnify icon |
A number of extensions also refer to this file directly, including VisualEditor and WikiEditor. These will need to be updated.
There are probably also innumerable user scripts that refer to it. Looking at bug 69277 comment 10, the Popups gadget is a big offender.
(In reply to Bartosz Dziewoński from comment #0)
(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
icon, but it would only affect the Vector skin.)
At this point this artefact would become a Monobook-only item, right? Should it be moved to that repo at that point?
(In reply to Bartosz Dziewoński from comment #1)
A number of extensions also refer to this file directly, including
VisualEditor and WikiEditor. These will need to be updated.
VisualEditor only uses it through mediawiki.content.styling.parsoid (faked Vector-like content rendering; yes yes, I know…), which should be fixed as the fixing for bug 65160.
(In reply to James Forrester from comment #2)
At this point this artefact would become a Monobook-only item, right? Should
it be moved to that repo at that point?
No, it would become every-skin-but-Vector-including-custom-skins-only item.
VisualEditor only uses it through mediawiki.content.styling.parsoid
It is also used in ve.ce.MWImageCaptionNode.js via 'magnifyClipIconURL' config item.
(In reply to Bartosz Dziewoński from comment #0)
Let's stop using inline <img> for thumbnail magnify icon. According to bug
69277 comment 11, there are 87619775 requests per day for
'magnify-clip.png'. It should be embedded in some piece of CSS.(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
icon, but it would only affect the Vector skin.)
Makes sense to me.
Change 154830 had a related patch set uploaded by Bartosz Dziewoński:
Generate 'Enlarge' image in CSS rather than HTML (Linker)
Change 154831 had a related patch set uploaded by Bartosz Dziewoński:
Remove WMF deployment hack for 'Enlarge' image
Change 154830 merged by jenkins-bot:
Generate 'Enlarge' image in CSS rather than HTML (Linker)
Deeming this merged now, as this is 'fixed' even without the clean-up from gerrit 154831 landing.
Change 161625 had a related patch set uploaded by Jforrester:
Remove WMF deployment hack for 'Enlarge' image