Track down popular gadgets that refer to files in skins/common/ and fix them not to.
Probably the best and simplest way is to upload offending files to Commons and update the URLs to point there.
Version: wmf-deployment
Severity: normal
matmarex | |
Aug 17 2014, 10:22 PM |
F14559: wikibits.js[1].log | |
Nov 22 2014, 3:39 AM |
F14558: ajax.js[1].log | |
Nov 22 2014, 3:39 AM |
Track down popular gadgets that refer to files in skins/common/ and fix them not to.
Probably the best and simplest way is to upload offending files to Commons and update the URLs to point there.
Version: wmf-deployment
Severity: normal
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Jdlrobson | T29292 Skinning system improvement (tracking) | |||
Resolved | matmarex | T71277 Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else | |||
Resolved | matmarex | T71678 Track down popular gadgets that refer to files in skins/common/ and fix them not to |
Created attachment 16223
mwgrep Arr_r, for contribsrange
First one for warmup: contribsrange.
attachment raw[1] ignored as obsolete
That and keep only one central copy of the gadget[1][2].
[1] https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_%28users%29#Keep_gadgets_central
[2] https://www.mediawiki.org/wiki/MediaWiki:Gadget-contribsrange.js
I don't like that because it decreases performance for users (by sidestepping RL request concatenation and this requiring more requests to load everything) and makes it impossible to express dependencies on such modules (because the actual loading is doubly-asynchronous). You can work on that if you want, I won't.
Me neither, but it is either doing that or having to fix the same things hundreds of times over and over again (or worse: keeping forks broken forever). I assume that is why this was recommended back in 2011...
(In reply to Bartosz Dziewoński from comment #1)
First one for warmup: contribsrange.
Done, example edit: https://en.wikipedia.org/w/index.php?diff=621826869
From b1dea1d957833d1965999c350a05d365ba56adba:
(I'll have the queries redone without the 100 results limit and attach them.)
The above stuff seems mostly gone.
Let's look at magnify-clip.png and bullet.gif a bit more and then close this.
magnify-clip.png is used almost exclusively by copies of the Navigation Popups gadget on 50 wikis or so. Conveniently, Popups does this well, using the same HTML structure as core, so this means that nothing will break if we just remove the image file.
I fixed the two other uses found in the MediaWiki namespace across all Wikimedia wikis:
https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-CommonsMedia.js&diff=172833809&oldid=139274853
https://no.wikipedia.org/w/index.php?title=MediaWiki:Gadget-youtube-player.js&diff=13508747&oldid=5472232
Replaced bullet.gif on a couple dozen wikis today. There are still a few matches, but it seems like they are all false positives or dead code. (In particular, there's a few copies of a gadget that does literally url(bullet.gif), which has never worked in the first place.)
I'm calling this done.