Page MenuHomePhabricator

Unclosed nested template adds nowiki on |, but not on the opening {{
Closed, DeclinedPublic

Description

https://fr.wikipedia.org/w/index.php?title=Eliaquim_Mangala&diff=106681571&oldid=106681205

One, can this be improved to detect the illogical unmatched transaction and warn about it ?

2nd, perhaps it can nowiki the {{ as well (I suspect this might be difficult...).

3rd, Perhaps the template editor UI itself can check for unmatched {{ }} in the field ?


Version: unspecified
Severity: normal

Details

Reference
bz69865

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:33 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz69865.

That's very odd – I can't reproduce the | getting converted to <nowiki>|</nowiki> with my own edits… Unclear if this is a Parsoid issue, possibly?

(When we have DOM-editing of templates' parameters, bug 50355, this will be moot.)

Yes, this is a bug in Parsoid's nowiki code for template args ... it should have added a nowiki around the whole string or also on the opening "{{".

Parsoid could possibly raise warnings about this to the client (VE in this case) ... but, not all clients might handle a non-standard response and do a back-and-forth negotiation. So, a little less unsure about it.

ssastry lowered the priority of this task from High to Medium.Nov 30 2014, 11:39 AM
ssastry moved this task from Needs Triage to In Progress on the Parsoid board.

This is such an old bug and so many things have changed with serialization, nowiki escaping, and DOM normalization to remove unnecessary nowikis that I am going to close this. If there are new bugs, I am sure they will be filed!