Page MenuHomePhabricator

2.0: Split "gadgets-edit" user right into "gadgets-edit-css" and "gadgets-edit-js"
Closed, DeclinedPublic

Description

MediaWiki core uses separate rights for editing user CSS and JS, and will[1] also have separate rights for site JS and CSS. This would make the extension more consistent with that.

[1] https://gerrit.wikimedia.org/r/#/c/154452/


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=8834

Details

Reference
bz69911

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:36 AM
bzimport set Reference to bz69911.
Krinkle claimed this task.

I don't think it's likely we would want to grant users the right to modify a gadget but restrict which resources. They should either be able to develop the program or not. Distinguishing between CSS and JS for this purpose in MediaWiki core doesn't serve any practical purpose either as far as I'm aware. It's a legacy artefact if anything. Not something we should aim to follow or duplicate in new developments.

Feel free to re-open with a use case. But at this point I'd prefer to close this and keep the gadget-edit right as one.

I don't think it's likely we would want to grant users the right to modify a gadget but restrict which resources. They should either be able to develop the program or not. Distinguishing between CSS and JS for this purpose in MediaWiki core doesn't serve any practical purpose either as far as I'm aware. It's a legacy artefact if anything. Not something we should aim to follow or duplicate in new developments.

The history here suggests otherwise (re: legacy artefact). JS and CSS were previously bundled as a single user right and were split into separate user rights in MediaWiki core.

I believe the general idea is that editing JavaScript is significantly riskier than editing CSS.

Feel free to re-open with a use case. But at this point I'd prefer to close this and keep the gadget-edit right as one.

This seems reasonable for now. I agree that a stronger argument than simple consistency should be made.