Page MenuHomePhabricator
Create Task
Maniphest T72061

Issues with dialog sizing on first open
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
Ryasmeen
Aug 26 2014, 7:47 PM
Tags
Referenced Files
F16138: good.png
Nov 25 2014, 7:13 PM
F16136: bad.png
Nov 25 2014, 7:13 PM
F15808: 2014-11-24_21_44_45-OOjs_UI_Demos_-_Opera.png
Nov 24 2014, 8:47 PM
F15810: 2014-11-24_21_45_03-OOjs_UI_Demos_-_Opera.png
Nov 24 2014, 8:47 PM
F15210: Screen_Shot_2014-11-13_at_8.59.07_AM.png
Nov 24 2014, 7:52 PM
F14221: Screen_Shot_2014-08-26_at_12.46.40_PM.png
Nov 24 2014, 6:20 PM
Subscribers
Catrope
Etonkovidova
Jdforrester-WMF
matmarex
Ryasmeen
Tokens
"Haypence" token, awarded by RandomDSdevel.

Description

Screenshot

Steps to reproduce:

  1. Open a page with VE
  2. Edit something in the edit mode
  3. Click on Read from the menu bar to navigate away from VE
  4. Observe the Confirmation dialog for discarding the edit

Observed Result:
There is a scroll bar appearing for the text area of the confirmation message and the buttons for "Discard edit" and "Continue Edit" are on top of each other instead of being next to each other.

Screen_Shot_2014-08-26_at_12.46.40_PM.png (254×379 px, 20 KB)

More visible with the "Message dialog (verbose)" from OOUI demo – first and next open side-by-side:

2014-11-24_21_44_45-OOjs_UI_Demos_-_Opera.png (621×336 px, 27 KB) 2014-11-24_21_45_03-OOjs_UI_Demos_-_Opera.png (602×342 px, 26 KB)

Details

Reference
bz70061
SubjectRepoBranchLines +/-
MessageDialog: Actually correctly calculate and set heightoojs/uimaster+25 -6
MessageDialog: Add Firefox hack for scrollbars when sizing dialogsoojs/uimaster+19 -0
Window: Disable transitions when changing window height to calculate content heightoojs/uimaster+13 -4
Customize query in gerrit

Revisions and Commits

rGOJU oojs-ui
rGOJU2882ecec630c Window: Disable transitions when changing window height to calculate content…
rGOJUcd2d7cafb235 Window: Disable transitions when changing window height to calculate content…
rGOJU0ec36b73fcd2 Window: Disable transitions when changing window height to calculate content…

Related Objects

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:29 AM
• bzimport added a project: OOUI.
• bzimport set Reference to bz70061.
Ryasmeen created this task.Aug 26 2014, 7:47 PM
Jdforrester-WMF added a comment.Sep 19 2014, 10:27 PM

Now fixed by Roan, I think.

Catrope added a comment.Sep 19 2014, 10:28 PM

It may no longer be happening in this particular instance, but we definitely still have bugs with button placement and sizing on first open in OOUI.

Jdforrester-WMF added a comment.Sep 19 2014, 10:41 PM

Eurgh, apparently not. :-(

matmarex added a comment.Sep 30 2014, 9:22 PM

Are there are particular issues known? Or reproduction instructions? This is "high priority" and completely not actionable :(

Jdforrester-WMF added a comment.Oct 3 2014, 6:06 PM

Bumping down priority until Roan gives reproductions steps.

Jdforrester-WMF added a comment.Nov 19 2014, 12:32 AM
  • Bug 73376 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a comment.Nov 19 2014, 12:33 AM

This has got a lot worse. :-(

Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Nov 24 2014, 2:38 AM
matmarex subscribed.Nov 24 2014, 10:24 AM

Can also be reproduced in the OOUI demo now.

matmarex renamed this task from OOjs UI: Issues with button placement and sizing on first open to OOjs UI: Issues with dialog button placement and sizing on first open.Nov 24 2014, 6:20 PM
matmarex set Security to None.
matmarex updated the task description. (Show Details)Nov 24 2014, 7:52 PM
matmarex mentioned this in T75783: MessageDialog does not re-fit actions on dialog resize.Nov 24 2014, 8:33 PM
matmarex added a comment.Nov 24 2014, 8:37 PM

I'm going to reopen bug 73376 (T75376), I think that's a different issue. (I just fixed that and this is still happening; calling .setSize() on a window that just opened changes its size slightly.)

matmarex updated the task description. (Show Details)Nov 24 2014, 8:38 PM
matmarex renamed this task from OOjs UI: Issues with dialog button placement and sizing on first open to OOjs UI: Issues with dialog sizing on first open.Nov 24 2014, 8:47 PM
matmarex updated the task description. (Show Details)
gerritbot added a project: Patch-For-Review.Nov 25 2014, 5:11 PM

Change 175743 had a related patch set uploaded (by Bartosz Dziewo?ski):
Window: Disable transitions when changing window height to calculate content height

https://gerrit.wikimedia.org/r/175743

Patch-For-Review

Jdforrester-WMF renamed this task from OOjs UI: Issues with dialog sizing on first open to Issues with dialog sizing on first open.Nov 25 2014, 5:14 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF moved this task from Next-up to Doing on the OOUI board.
gerritbot added a comment.Nov 25 2014, 7:08 PM

Change 175782 had a related patch set uploaded (by Bartosz Dziewo?ski):
MessageDialog: Add Firefox hack for scrollbars when sizing dialogs

https://gerrit.wikimedia.org/r/175782

Patch-For-Review

matmarex added a comment.Nov 25 2014, 7:13 PM

For posterity, here are screenshots of the Firefox bug the patch above fixes:

Without the hackWith the hack
bad.png (596×347 px, 23 KB)
good.png (596×347 px, 23 KB)
gerritbot added a comment.Nov 26 2014, 2:00 AM

Change 175926 had a related patch set uploaded (by Bartosz Dziewo?ski):
MessageDialog: Actually correctly calculate and set height

https://gerrit.wikimedia.org/r/175926

Patch-For-Review

gerritbot added a comment.Nov 26 2014, 8:51 PM

Change 175743 merged by jenkins-bot:
Window: Disable transitions when changing window height to calculate content height

https://gerrit.wikimedia.org/r/175743

gerritbot added a comment.Nov 26 2014, 8:51 PM

Change 175782 merged by jenkins-bot:
MessageDialog: Add Firefox hack for scrollbars when sizing dialogs

https://gerrit.wikimedia.org/r/175782

gerritbot added a comment.Nov 26 2014, 10:47 PM

Change 175926 merged by jenkins-bot:
MessageDialog: Actually correctly calculate and set height

https://gerrit.wikimedia.org/r/175926

matmarex added a comment.Nov 26 2014, 10:54 PM

This should be all fixed now. Rigorous testing would be very useful, though.

Jdforrester-WMF closed this task as Resolved.Nov 26 2014, 10:58 PM
Jdforrester-WMF added a project: WMF-deploy-2014-12-03-(1.25wmf11).
Jdforrester-WMF removed a project: Patch-For-Review.Dec 4 2014, 9:48 PM
Etonkovidova added a comment.Dec 4 2014, 11:32 PM

Checked in prod/test2/beta - Chrome, FF, and Safari.

Etonkovidova added projects: Verified-in-Phase0, Verified-in-Phase2.Dec 4 2014, 11:33 PM
RandomDSdevel awarded a token.Dec 15 2014, 11:14 PM
RandomDSdevel rescinded a token.
RandomDSdevel awarded a token.
matmarex added a commit: rGOJU0ec36b73fcd2: Window: Disable transitions when changing window height to calculate content….Mar 3 2015, 7:20 PM
matmarex mentioned this in rGOJU7961f9262d99: MessageDialog: Add Firefox hack for scrollbars when sizing dialogs.Mar 3 2015, 7:49 PM
Jdforrester-WMF mentioned this in rGOJU141a0d7ae158: MessageDialog: Actually correctly calculate and set height.Mar 3 2015, 7:49 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM
matmarex added a commit: rGOJUcd2d7cafb235: Window: Disable transitions when changing window height to calculate content….Apr 28 2016, 1:25 AM
matmarex added a commit: rGOJU2882ecec630c: Window: Disable transitions when changing window height to calculate content….
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL