Page MenuHomePhabricator

other projects feature broken with $wgEnableSidebarCache = true
Closed, ResolvedPublic

Description

If $wgEnableSidebarCache = true, it seems the other projects feature doesn't work correct. This is the case on zhwiki.

The sidebar is put into a shared cache for the entire wiki ("zhwiki:sidebar:zh"). Extensions can then use the SidebarBeforeOutput hook to modify both cached and uncached sidebar, but the SkinBuildSidebar (which wikibase uses) is not run for cached sidebar.

For most wmf wikis $wgEnableSidebarCache is set to false, but apparently only for wikis with the Collection extension (most wikis! but not zhwiki and various others) due to problems that extension has with sidebar cache.


Version: unspecified
Severity: major
Whiteboard: u=dev c=backend p=2 s=2014-08-26

Details

Reference
bz70234

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:40 AM
bzimport set Reference to bz70234.
bzimport added a subscriber: Unknown Object (MLST).

Change 157500 had a related patch set uploaded by Aude:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/157500

Change 157500 merged by jenkins-bot:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/157500

Change 159034 had a related patch set uploaded by Aude:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/159034

Change 159034 merged by jenkins-bot:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/159034