Page MenuHomePhabricator

FA and GA icons not showing on language links in MonoBook skin on enwp
Closed, ResolvedPublic

Description

FA and GA icons are shown next to language links where these articles have that status on the linked wiki. In Monobook these are not showing, or they are not all showing. Some examples:

English Wikipeia page https://en.wikipedia.org/wiki/Delian_League
Wikidata page https://www.wikidata.org/wiki/Q193235#sitelinks-wikipedia

The equivalent article is an FA on Hungarian (Magyar) Wikipedia but icon does not show on Monobook skin.

English Wikipedia page https://en.wikipedia.org/wiki/Diamond
Wikidata page https://www.wikidata.org/wiki/Q5283#sitelinks-wikipedia

The equivalent article is an FA on Esperanto, Latvian, and Hungarian Wikipedias, and a GA on German and Estonian Wikipedias. Only the Esperanto star is showing on Monobooks.

The Aspirin article is another example. In all cases ths icons are visible when viewed in Vector and seem to be properly marked in Wikidata.


Version: unspecified
Severity: normal

Details

Reference
bz70280

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:43 AM
bzimport set Reference to bz70280.
bzimport added a subscriber: Unknown Object (MLST).

It appears that a rule in enwp's [[MediaWiki:Common.css]] is overriding the badge styling.

/* Portlet bullets */
.portlet li {

list-style-image: url(//upload.wikimedia.org/wikipedia/en/1/18/Monobook-bullet.png);

}

I'm not sure if we can remove that rule safely...cc'd a few people who might know.

My quick mwgrepping shows that this rule is present on a lot more wikis than just enwp... :|

(In reply to Kunal Mehta (Legoktm) from comment #1)

It appears that a rule in enwp's [[MediaWiki:Common.css]]

[[MediaWiki:Monobook.css]], actually.

It can be safely killed, MonoBook implements these styles itself…

(In reply to Kunal Mehta (Legoktm) from comment #1)

It appears that a rule in enwp's [[MediaWiki:Common.css]] is overriding the
badge styling.

Based on that, this bug would be INVALID since it's just a problem with on-wiki css rather than anything at all in MediaWiki, or in Wikimedia site configuration.

(In reply to Kunal Mehta (Legoktm) from comment #2)

My quick mwgrepping shows that this rule is present on a lot more wikis than
just enwp... :|

Although that means Bugzilla might be useful to coordinate the general cleanup. It wouldn't surprise me if the "lot more wikis" copied it from enwiki.

FWIW, it was added on enwiki in November 2006, https://en.wikipedia.org/w/index.php?diff=prev&oldid=89307273. Unfortunately the edit summaries don't indicate why it was done.

Removed the offending (and completely redundant) rule from monobook.css. FA/GA stars/bullets are showing again in Monobook.

This already got fixed in the WikimediaBadges extension and should show up with the next deployment. See https://github.com/wmde/WikimediaBadges/pull/10